From: linas <linas@austin.ibm.com>
To: "linux-os (Dick Johnson)" <linux-os@analogic.com>
Cc: Vadim Lobanov <vlobanov@speakeasy.net>,
"J.A. Magallon" <jamagallon@able.es>,
Kyle Moffett <mrmacman_g4@mac.com>,
Douglas McNaught <doug@mcnaught.org>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org,
bluesmoke-devel@lists.sourceforge.net,
linux-pci@atrey.karlin.mff.cuni.cz, linuxppc64-dev@ozlabs.org
Subject: Re: typedefs and structs
Date: Wed, 9 Nov 2005 17:29:44 -0600 [thread overview]
Message-ID: <20051109232944.GV19593@austin.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0511091459440.12760@chaos.analogic.com>
On Wed, Nov 09, 2005 at 03:26:10PM -0500, linux-os (Dick Johnson) was heard to remark:
>
> On Wed, 9 Nov 2005, linas wrote:
>
> > On Wed, Nov 09, 2005 at 08:22:15AM -0800, Vadim Lobanov was heard to remark:
> >> On Wed, 9 Nov 2005, J.A. Magallon wrote:
> >>
> >>> void do_some_stuff(T& arg1,T& arg2)
> >>
> >> A diligent C programmer would write this as follows:
> >> void do_some_stuff (struct T * a, struct T * b);
> >> So I don't see C++ winning at all here.
> >
> > I guess the real point that I'd wanted to make, and seems
> > to have gotten lost, was that by avoiding using pointers,
> > you end up designing code in a very different way, and you
> > can find out that often/usually, you don't need structs
> > filled with a zoo of pointers.
>
> But you can't avoid pointers unless you make your entire
> program have global scope.
I didn't say you can avoid all pointers. I did say that
for many projects, one can often avoid many pointers.
And I certainly did not say that one needs global scope
to do so. In fact, I said the opposite.
> Also, without pointers, you are severely limited on the kinds
> of libraries you can share.
I think you don't understand what a reference is.
A reference is just like a pointer, except that the
signature is different. It has nothing to do with the
ability to create or use libraries, or to create/use
modular code.
I was trying to say that by focusing on the concept
of a "reference" as opposed to the concept of a
"pointer", you can write code that is *more* modular,
not less.
> > Minimizing pointers is good: less ref counting is needed,
> > fewer mallocs are needed, fewer locks are needed
> > (because of local/private scope!!), and null pointer
> > deref errors are less likely.
>
> No. Minimizing pointers should not be an objective.
Why not?
I've fixed hundreds of kernel bugs (which you don't
see on this list because my fixes mostly go to the
distros or other users) and nine out of ten of these
are null-pointer derefs.
Maybe I'm naive for thinking that "fewer pointers ==
fewer pointer bugs" but, hey its worth a shot.
> Properly
> using the components of your tool-set should be.
What tool set are you refering to? I am assuming
that the code is 100% malleable: that one has
complete authority to redesign the way the system
works, from the ground up. If you do not have this
freedom, but are forced to use someone-else's tool set,
then yes, you are SOL. Furthermore, I would agree
that mixing two different styles of coding in one
project can lead to some nasty, ugly code.
> > By using refs instead of pointers, it helps you focus
> > on the issue of "do I really need to store this pointer
> > somewhere? Will I really need it later, or can I be done
> > with it now?".
>
> Huh? References (at the opcode level) are pointers. There
> is no difference whatsoever.
Yes, that is right. I'm not talking about opcodes.
That's not what the conversation is about.
What I am trying to say is that many people design
code in such a way that they need to store lots of
pointers in an assortment of structs.
I wanted to emphasize that there are other ways of
designing code, which has smaller needs for pointers
(and that this can be done without loosing modularity,
testability, debugability, and it can be done without
resorting to global variables.)
--linas
next prev parent reply other threads:[~2005-11-09 23:29 UTC|newest]
Thread overview: 131+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-03 23:59 [PATCH 0/42] PCI Error Recovery for PPC64 and misc device drivers Linas Vepstas
2005-11-04 0:42 ` [PATCH 1/42] ppc64: uniform usage of bus unit id interfaces linas
2005-11-04 0:47 ` [PATCH 2/42]: ppc64: misc minor cleanup Linas Vepstas
2005-11-04 0:48 ` [PATCH 3/42]: ppc64: PCI address cache minor fixes Linas Vepstas
2005-11-04 0:48 ` [PATCH 4/42]: ppc64: PCI error rate statistics Linas Vepstas
2005-11-04 0:49 ` [PATCH 5/42]: ppc64: RTAS error reporting restructuring Linas Vepstas
2005-11-04 0:49 ` [PATCH 6/42]: ppc64: avoid PCI error reporting for empty slots Linas Vepstas
2005-11-04 0:49 ` [PATCH 7/42]: ppc64: serialize reports of PCI errors Linas Vepstas
2005-11-04 0:49 ` [PATCH 8/42]: ppc64: escape hatch for spinning interrupt deadlocks Linas Vepstas
2005-11-04 0:49 ` [PATCH 9/42]: ppc64: bugfix: crash on PCI hotplug Linas Vepstas
2005-11-04 0:49 ` [PATCH 10/42]: ppc64: bugfix: don't silently gnore PCI errors Linas Vepstas
2005-11-04 0:49 ` [PATCH 11/42]: ppc64: move code to powerpc directory from ppc64 Linas Vepstas
2005-11-04 0:50 ` [PATCH 12/42]: ppc64: PCI error event dispatcher Linas Vepstas
2005-11-04 0:50 ` [PATCH 13/42]: ppc64: PCI reset support routines Linas Vepstas
2005-11-04 0:50 ` [PATCH 14/42]: ppc64: Save & restore of PCI device BARS Linas Vepstas
2005-11-04 0:50 ` [PATCH 15/42]: Documentation: PCI Error Recovery Linas Vepstas
2005-11-04 0:50 ` [PATCH 16/42]: PCI: PCI Error reporting callbacks Linas Vepstas
2005-11-05 6:11 ` Greg KH
2005-11-06 23:25 ` Paul Mackerras
2005-11-07 17:55 ` linas
2005-11-07 18:27 ` Greg KH
2005-11-07 18:56 ` typedefs and structs [was Re: [PATCH 16/42]: PCI: PCI Error reporting callbacks] linas
2005-11-07 19:02 ` Greg KH
2005-11-07 19:36 ` linas
2005-11-07 20:02 ` Greg KH
2005-11-07 20:41 ` linas
2005-11-07 20:46 ` Greg KH
2005-11-08 1:11 ` Steven Rostedt
2005-11-08 1:18 ` Neil Brown
2005-11-08 23:36 ` typedefs and structs linas
2005-12-16 13:09 ` typedefs and structs [was Re: [PATCH 16/42]: PCI: PCI Error reporting callbacks] Denis Vlasenko
2005-12-16 13:22 ` Matthew Wilcox
2005-11-08 23:23 ` typedefs and structs linas
2005-11-08 23:33 ` Steven Rostedt
2005-11-09 9:22 ` Bernd Petrovitsch
2005-11-08 23:57 ` Kyle Moffett
2005-11-09 0:30 ` linas
2005-11-09 0:37 ` Douglas McNaught
2005-11-09 0:48 ` linas
2005-11-09 0:59 ` Douglas McNaught
2005-11-09 2:14 ` Dmitry Torokhov
2005-11-09 1:51 ` Kyle Moffett
2005-11-09 10:16 ` J.A. Magallon
2005-11-09 16:22 ` Vadim Lobanov
2005-11-09 19:20 ` linas
2005-11-09 19:36 ` thockin
2005-11-09 19:38 ` linas
2005-11-09 20:39 ` thockin
2005-11-09 21:53 ` Andreas Schwab
2005-11-09 22:00 ` Bernd Petrovitsch
2005-11-09 20:55 ` Matthew Wilcox
2005-11-09 20:26 ` linux-os (Dick Johnson)
2005-11-09 22:12 ` Vadim Lobanov
2005-11-09 22:37 ` linux-os (Dick Johnson)
2005-11-09 22:47 ` Vadim Lobanov
2005-11-09 22:54 ` typedefs and structs - trim request doug thompson
2005-11-09 23:29 ` typedefs and structs Andreas Schwab
2005-11-09 23:40 ` Vadim Lobanov
2005-11-10 3:39 ` Steven Rostedt
2005-11-10 3:49 ` Vadim Lobanov
2005-11-10 8:15 ` J.A. Magallon
2005-11-10 13:27 ` Nikita Danilov
2005-11-10 14:18 ` linux-os (Dick Johnson)
2005-11-10 19:21 ` Kyle Moffett
2005-11-10 19:28 ` Vadim Lobanov
2005-11-10 20:53 ` J.A. Magallon
2005-11-09 23:29 ` linas [this message]
2005-11-09 21:43 ` Vadim Lobanov
2005-11-10 0:27 ` linas
2005-11-08 23:57 ` David Gibson
2005-11-09 0:13 ` Zan Lynx
2005-11-09 0:42 ` linas
2005-11-09 9:25 ` Bernd Petrovitsch
2005-11-07 19:04 ` typedefs and structs [was Re: [PATCH 16/42]: PCI: PCI Error reporting callbacks] Randy.Dunlap
2005-11-07 19:57 ` [PATCH 1/7]: PCI revised [PATCH 16/42]: PCI: PCI Error reporting callbacks linas
2005-11-07 19:59 ` Christoph Hellwig
2005-11-07 20:03 ` Greg KH
2005-11-07 21:21 ` [PATCH 1/7]: PCI revised (2) " linas
2005-11-07 21:37 ` Greg KH
2005-11-07 21:54 ` Linus Torvalds
2005-11-07 22:54 ` Greg KH
2005-11-07 22:43 ` [PATCH 1/7]: PCI revised (3) " linas
2005-11-07 22:53 ` Greg KH
2005-11-07 23:19 ` linas
2005-11-08 2:43 ` Greg KH
2005-11-07 21:30 ` [PATCH 2/7]: Revised [PATCH 27/42]: SCSI: add PCI error recovery to IPR dev driver linas
2005-11-07 21:40 ` Brian King
2005-11-07 22:03 ` linas
2005-11-07 21:31 ` [PATCH 3/7]: Revised [PATCH 28/42]: SCSI: add PCI error recovery to Symbios " linas
2005-11-07 21:34 ` [PATCH 4/7]: Revised [PATCH 29/42]: ethernet: add PCI error recovery to e100 " linas
2005-11-07 21:36 ` [PATCH: 5/7]: Revised: [PATCH 30/42]: ethernet: add PCI error recovery to e1000 " linas
2005-11-07 21:37 ` [PATCH 6/7]: Revised [PATCH 31/42]: ethernet: add PCI error recovery to ixgb " linas
2005-11-07 21:39 ` [PATCH 7/7]: Revised [PATCH 32/42]: RFC: Add compile-time config options linas
2005-11-04 0:50 ` [PATCH 17/42]: ppc64: mark failed devices Linas Vepstas
2005-11-04 0:51 ` [PATCH 18/42]: ppc64: bugfix: crash on dlpar slot add, remove Linas Vepstas
2005-11-04 0:51 ` [PATCH 19/42]: ppc64: bugfix: crash on PHB add Linas Vepstas
2005-11-04 16:20 ` John Rose
2005-11-04 16:35 ` linas
2005-11-04 0:51 ` [PATCH 20/42]: ppc64: PCI hotplug common code elimination Linas Vepstas
2005-11-04 0:51 ` [PATCH 21/42]: PCI: cleanup/simplify ppc64 PCI hotplug code Linas Vepstas
2005-11-04 0:52 ` [PATCH 22/42]: PCI: remove duplicted pci " Linas Vepstas
2005-11-04 21:54 ` John Rose
2005-11-04 0:52 ` [PATCH 23/42]: ppc64: migrate common PCI " Linas Vepstas
2005-11-04 0:52 ` [PATCH 24/42]: ppc64: PCI Error Recovery: PPC64 core recovery routines Linas Vepstas
2005-11-04 0:53 ` [PATCH 25/42]: ppc64: Split out PCI address cache to its own file Linas Vepstas
2005-11-04 0:53 ` [PATCH 26/42]: ppc64: Add "partion endpoint" support Linas Vepstas
2005-11-04 0:53 ` [PATCH 27/42]: SCSI: add PCI error recovery to IPR dev driver Linas Vepstas
2005-11-04 0:53 ` [PATCH 28/42]: SCSI: add PCI error recovery to Symbios " Linas Vepstas
2005-11-04 0:53 ` [PATCH 29/42]: ethernet: add PCI error recovery to e100 " Linas Vepstas
2005-11-04 1:34 ` Jesse Brandeburg
2005-11-04 1:51 ` Jesse Brandeburg
2005-11-04 0:54 ` [PATCH 30/42]: ethernet: add PCI error recovery to e1000 " Linas Vepstas
2005-11-04 0:54 ` [PATCH 31/42]: ethernet: add PCI error recovery to ixgb " Linas Vepstas
2005-11-04 0:54 ` [PATCH 32/42]: RFC: Add compile-time config options Linas Vepstas
2005-11-04 0:54 ` [PATCH 33/42]: ppc64: remove bogus printk Linas Vepstas
2005-11-04 0:54 ` [PATCH 34/42]: ppc64: Remove duplicate code Linas Vepstas
2005-11-04 0:54 ` [PATCH 35/42]: ppc64: bugfix: fill in un-initialzed field Linas Vepstas
2005-11-04 0:54 ` [PATCH 36/42]: ppc64: Use PE configuration address consistently Linas Vepstas
2005-11-04 0:54 ` [PATCH 37/42]: ppc64: set up the RTAS token just like the rest of them Linas Vepstas
2005-11-04 0:54 ` [PATCH 38/42]: ppc64: Don't continue with PCI Error recovery if slot reset failed Linas Vepstas
2005-11-04 0:55 ` [PATCH 39/42]: ppc64: handle multifunction PCI devices properly Linas Vepstas
2005-11-04 0:55 ` [PATCH 40/42]: ppc64: IOMMU: don't ioremap null pointers Linas Vepstas
2005-11-04 0:55 ` [PATCH 41/42]: ppc64: Save device BARS much earlier in the boot sequence Linas Vepstas
2005-11-04 22:14 ` linas
2005-11-04 0:55 ` [PATCH 42/42]: ppc64: get rid of per_cpu counters Linas Vepstas
2005-11-04 0:57 ` [PATCH 11/42]: ppc64: move code to powerpc directory from ppc64 Linas Vepstas
2005-11-04 22:14 ` [PATCH 0/42] PCI Error Recovery for PPC64 and misc device drivers Greg KH
2005-11-05 0:08 ` Paul Mackerras
2005-11-05 0:28 ` Greg KH
2005-11-05 0:46 ` Paul Mackerras
2005-11-05 1:28 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051109232944.GV19593@austin.ibm.com \
--to=linas@austin.ibm.com \
--cc=bluesmoke-devel@lists.sourceforge.net \
--cc=doug@mcnaught.org \
--cc=jamagallon@able.es \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-os@analogic.com \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linuxppc64-dev@ozlabs.org \
--cc=mrmacman_g4@mac.com \
--cc=rostedt@goodmis.org \
--cc=vlobanov@speakeasy.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®