mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: linas <linas@austin.ibm.com>
To: Vadim Lobanov <vlobanov@speakeasy.net>
Cc: "J.A. Magallon" <jamagallon@able.es>,
	Kyle Moffett <mrmacman_g4@mac.com>,
	Douglas McNaught <doug@mcnaught.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel@vger.kernel.org, linuxppc64-dev@ozlabs.org
Subject: Re: typedefs and structs
Date: Wed, 9 Nov 2005 18:27:47 -0600	[thread overview]
Message-ID: <20051110002746.GW19593@austin.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0511091339090.31338@shell3.speakeasy.net>

On Wed, Nov 09, 2005 at 01:43:10PM -0800, Vadim Lobanov was heard to remark:
> On Wed, 9 Nov 2005, linas wrote:
> 
> > I guess the real point that I'd wanted to make, and seems
> > to have gotten lost, was that by avoiding using pointers,
> > you end up designing code in a very different way, and you
> > can find out that often/usually, you don't need structs
> > filled with a zoo of pointers.
> >
> > Minimizing pointers is good: less ref counting is needed,
> > fewer mallocs are needed, fewer locks are needed
> > (because of local/private scope!!), and null pointer
> > deref errors are less likely.
> >
> > There are even performance implications: on modern CPU's
> > there's a very long pipeline to memory (hundreds of cycles
> > for a cache miss! Really! Worse if you have run out of
> > TLB entries!). So walking a long linked list chasing
> > pointers can really really hurt performance.
> >
> > By using refs instead of pointers, it helps you focus
> > on the issue of "do I really need to store this pointer
> > somewhere? Will I really need it later, or can I be done
> > with it now?".
> >
> > I don't know if the idea of "using fewer pointers" can
> > actually be carried out in the kernel. For starters,
> > the stack is way too short to be able to put much on it.
> 
> I really see the two issues at hand as being very much orthogonal to
> each other.

Yes. I accidentally linked them, see below.

> Namely, you put data on the stack when you need it in the local
> 'context' only, whereas you put data globally when it needs to be
> available globally. 

Yes. But there's some flexibility.

> The C++ references are nothing more than syntactic
> sugar (and we all know what they say about that and semicolons) for
> pointers,
 
Yes.

> and so I don't see how they would affect the choices at all.
> Choosing where the data goes should be done according to the data's
> lifetime, not the specifics of how functions are declared.

My apologies for linking the idea of references to fewer pointers.
They're not linked, except in how I discovered them.

I once had a project (that used threads, so it was "kernel-like",
in that race conditions had to be dealt with).  One day, for the 
the hell of it, I decided to create a struct and keep it on the 
stack, instead of mallocing it.  Since this struct was accessed 
only by a few small, well-defined routines that did not keep any 
pointers to it, this worked just fine. And skipping the malloc/free
felt good, so I liked it.

Then I thought that maybe I could push the idea, see how far I 
could go. Well, of course, the code was filled with various 
objects, all of which *seemed* to be (or seemed to need to be) 
long-lifetime objects. And they all stored pointers to one-another,
since they all needed to get access to one-another at various points,
for various reasons. 

Well, I really wanted to alloc objects on stack, and so that forced
me to think about how to get rid of pointers (since a pointer to 
an object on stack is deadly). And that forced me to think about
lifetime. And some of this thinking was quite hard.  But encouraged
by some modest success at first, I found that I was able to 
eliminate almost all the pointers, and almost all the mallocs 
(maybe several dozen of each, scattered accross maybe several dozen
structs). And I was flabbergasted, since the resulting program
actually got smaller in the process, and faster. And the 
null-pointer derefs vanished. 

Now, maybe this was specific to the project, and can't be replicated
elsewhere.  But this was a communcations daemon: it basically 
was a pool of threads, each thread handling a long-lived,
stateful "session" of requests and responses from some remote server,
and so while its not the kernel, that's a reasonably complex thing. 

I'm not crazy enough to suggest that one could do the same thing 
in the Linux kernel, since one probably can't, but now that we're 
here and all, it does make me wonder.  FWIW, the two designs of
the commo daemon were radically different; things that were sliced 
one way got reworked to flow and be handled in a completely 
different order.  You can't just get rid of pointers with some 
trivial restructuring; you have to figure out how not to need them.

--linas

  reply	other threads:[~2005-11-10  0:27 UTC|newest]

Thread overview: 131+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-03 23:59 [PATCH 0/42] PCI Error Recovery for PPC64 and misc device drivers Linas Vepstas
2005-11-04  0:42 ` [PATCH 1/42] ppc64: uniform usage of bus unit id interfaces linas
2005-11-04  0:47 ` [PATCH 2/42]: ppc64: misc minor cleanup Linas Vepstas
2005-11-04  0:48 ` [PATCH 3/42]: ppc64: PCI address cache minor fixes Linas Vepstas
2005-11-04  0:48 ` [PATCH 4/42]: ppc64: PCI error rate statistics Linas Vepstas
2005-11-04  0:49 ` [PATCH 5/42]: ppc64: RTAS error reporting restructuring Linas Vepstas
2005-11-04  0:49 ` [PATCH 6/42]: ppc64: avoid PCI error reporting for empty slots Linas Vepstas
2005-11-04  0:49 ` [PATCH 7/42]: ppc64: serialize reports of PCI errors Linas Vepstas
2005-11-04  0:49 ` [PATCH 8/42]: ppc64: escape hatch for spinning interrupt deadlocks Linas Vepstas
2005-11-04  0:49 ` [PATCH 9/42]: ppc64: bugfix: crash on PCI hotplug Linas Vepstas
2005-11-04  0:49 ` [PATCH 10/42]: ppc64: bugfix: don't silently gnore PCI errors Linas Vepstas
2005-11-04  0:49 ` [PATCH 11/42]: ppc64: move code to powerpc directory from ppc64 Linas Vepstas
2005-11-04  0:50 ` [PATCH 12/42]: ppc64: PCI error event dispatcher Linas Vepstas
2005-11-04  0:50 ` [PATCH 13/42]: ppc64: PCI reset support routines Linas Vepstas
2005-11-04  0:50 ` [PATCH 14/42]: ppc64: Save & restore of PCI device BARS Linas Vepstas
2005-11-04  0:50 ` [PATCH 15/42]: Documentation: PCI Error Recovery Linas Vepstas
2005-11-04  0:50 ` [PATCH 16/42]: PCI: PCI Error reporting callbacks Linas Vepstas
2005-11-05  6:11   ` Greg KH
2005-11-06 23:25     ` Paul Mackerras
2005-11-07 17:55       ` linas
2005-11-07 18:27         ` Greg KH
2005-11-07 18:56           ` typedefs and structs [was Re: [PATCH 16/42]: PCI: PCI Error reporting callbacks] linas
2005-11-07 19:02             ` Greg KH
2005-11-07 19:36               ` linas
2005-11-07 20:02                 ` Greg KH
2005-11-07 20:41                   ` linas
2005-11-07 20:46                     ` Greg KH
2005-11-08  1:11                     ` Steven Rostedt
2005-11-08  1:18                       ` Neil Brown
2005-11-08 23:36                         ` typedefs and structs linas
2005-12-16 13:09                         ` typedefs and structs [was Re: [PATCH 16/42]: PCI: PCI Error reporting callbacks] Denis Vlasenko
2005-12-16 13:22                           ` Matthew Wilcox
2005-11-08 23:23                       ` typedefs and structs linas
2005-11-08 23:33                         ` Steven Rostedt
2005-11-09  9:22                           ` Bernd Petrovitsch
2005-11-08 23:57                         ` Kyle Moffett
2005-11-09  0:30                           ` linas
2005-11-09  0:37                             ` Douglas McNaught
2005-11-09  0:48                               ` linas
2005-11-09  0:59                                 ` Douglas McNaught
2005-11-09  2:14                                   ` Dmitry Torokhov
2005-11-09  1:51                                 ` Kyle Moffett
2005-11-09 10:16                                   ` J.A. Magallon
2005-11-09 16:22                                     ` Vadim Lobanov
2005-11-09 19:20                                       ` linas
2005-11-09 19:36                                         ` thockin
2005-11-09 19:38                                           ` linas
2005-11-09 20:39                                             ` thockin
2005-11-09 21:53                                               ` Andreas Schwab
2005-11-09 22:00                                                 ` Bernd Petrovitsch
2005-11-09 20:55                                             ` Matthew Wilcox
2005-11-09 20:26                                         ` linux-os (Dick Johnson)
2005-11-09 22:12                                           ` Vadim Lobanov
2005-11-09 22:37                                             ` linux-os (Dick Johnson)
2005-11-09 22:47                                               ` Vadim Lobanov
2005-11-09 22:54                                               ` typedefs and structs - trim request doug thompson
2005-11-09 23:29                                             ` typedefs and structs Andreas Schwab
2005-11-09 23:40                                               ` Vadim Lobanov
2005-11-10  3:39                                                 ` Steven Rostedt
2005-11-10  3:49                                                   ` Vadim Lobanov
2005-11-10  8:15                                             ` J.A. Magallon
2005-11-10 13:27                                               ` Nikita Danilov
2005-11-10 14:18                                                 ` linux-os (Dick Johnson)
2005-11-10 19:21                                                 ` Kyle Moffett
2005-11-10 19:28                                                   ` Vadim Lobanov
2005-11-10 20:53                                                     ` J.A. Magallon
2005-11-09 23:29                                           ` linas
2005-11-09 21:43                                         ` Vadim Lobanov
2005-11-10  0:27                                           ` linas [this message]
2005-11-08 23:57                         ` David Gibson
2005-11-09  0:13                           ` Zan Lynx
2005-11-09  0:42                             ` linas
2005-11-09  9:25                               ` Bernd Petrovitsch
2005-11-07 19:04             ` typedefs and structs [was Re: [PATCH 16/42]: PCI: PCI Error reporting callbacks] Randy.Dunlap
2005-11-07 19:57           ` [PATCH 1/7]: PCI revised [PATCH 16/42]: PCI: PCI Error reporting callbacks linas
2005-11-07 19:59             ` Christoph Hellwig
2005-11-07 20:03             ` Greg KH
2005-11-07 21:21               ` [PATCH 1/7]: PCI revised (2) " linas
2005-11-07 21:37                 ` Greg KH
2005-11-07 21:54                   ` Linus Torvalds
2005-11-07 22:54                     ` Greg KH
2005-11-07 22:43                   ` [PATCH 1/7]: PCI revised (3) " linas
2005-11-07 22:53                     ` Greg KH
2005-11-07 23:19                       ` linas
2005-11-08  2:43                         ` Greg KH
2005-11-07 21:30             ` [PATCH 2/7]: Revised [PATCH 27/42]: SCSI: add PCI error recovery to IPR dev driver linas
2005-11-07 21:40               ` Brian King
2005-11-07 22:03                 ` linas
2005-11-07 21:31             ` [PATCH 3/7]: Revised [PATCH 28/42]: SCSI: add PCI error recovery to Symbios " linas
2005-11-07 21:34             ` [PATCH 4/7]: Revised [PATCH 29/42]: ethernet: add PCI error recovery to e100 " linas
2005-11-07 21:36             ` [PATCH: 5/7]: Revised: [PATCH 30/42]: ethernet: add PCI error recovery to e1000 " linas
2005-11-07 21:37             ` [PATCH 6/7]: Revised [PATCH 31/42]: ethernet: add PCI error recovery to ixgb " linas
2005-11-07 21:39             ` [PATCH 7/7]: Revised [PATCH 32/42]: RFC: Add compile-time config options linas
2005-11-04  0:50 ` [PATCH 17/42]: ppc64: mark failed devices Linas Vepstas
2005-11-04  0:51 ` [PATCH 18/42]: ppc64: bugfix: crash on dlpar slot add, remove Linas Vepstas
2005-11-04  0:51 ` [PATCH 19/42]: ppc64: bugfix: crash on PHB add Linas Vepstas
2005-11-04 16:20   ` John Rose
2005-11-04 16:35     ` linas
2005-11-04  0:51 ` [PATCH 20/42]: ppc64: PCI hotplug common code elimination Linas Vepstas
2005-11-04  0:51 ` [PATCH 21/42]: PCI: cleanup/simplify ppc64 PCI hotplug code Linas Vepstas
2005-11-04  0:52 ` [PATCH 22/42]: PCI: remove duplicted pci " Linas Vepstas
2005-11-04 21:54   ` John Rose
2005-11-04  0:52 ` [PATCH 23/42]: ppc64: migrate common PCI " Linas Vepstas
2005-11-04  0:52 ` [PATCH 24/42]: ppc64: PCI Error Recovery: PPC64 core recovery routines Linas Vepstas
2005-11-04  0:53 ` [PATCH 25/42]: ppc64: Split out PCI address cache to its own file Linas Vepstas
2005-11-04  0:53 ` [PATCH 26/42]: ppc64: Add "partion endpoint" support Linas Vepstas
2005-11-04  0:53 ` [PATCH 27/42]: SCSI: add PCI error recovery to IPR dev driver Linas Vepstas
2005-11-04  0:53 ` [PATCH 28/42]: SCSI: add PCI error recovery to Symbios " Linas Vepstas
2005-11-04  0:53 ` [PATCH 29/42]: ethernet: add PCI error recovery to e100 " Linas Vepstas
2005-11-04  1:34   ` Jesse Brandeburg
2005-11-04  1:51     ` Jesse Brandeburg
2005-11-04  0:54 ` [PATCH 30/42]: ethernet: add PCI error recovery to e1000 " Linas Vepstas
2005-11-04  0:54 ` [PATCH 31/42]: ethernet: add PCI error recovery to ixgb " Linas Vepstas
2005-11-04  0:54 ` [PATCH 32/42]: RFC: Add compile-time config options Linas Vepstas
2005-11-04  0:54 ` [PATCH 33/42]: ppc64: remove bogus printk Linas Vepstas
2005-11-04  0:54 ` [PATCH 34/42]: ppc64: Remove duplicate code Linas Vepstas
2005-11-04  0:54 ` [PATCH 35/42]: ppc64: bugfix: fill in un-initialzed field Linas Vepstas
2005-11-04  0:54 ` [PATCH 36/42]: ppc64: Use PE configuration address consistently Linas Vepstas
2005-11-04  0:54 ` [PATCH 37/42]: ppc64: set up the RTAS token just like the rest of them Linas Vepstas
2005-11-04  0:54 ` [PATCH 38/42]: ppc64: Don't continue with PCI Error recovery if slot reset failed Linas Vepstas
2005-11-04  0:55 ` [PATCH 39/42]: ppc64: handle multifunction PCI devices properly Linas Vepstas
2005-11-04  0:55 ` [PATCH 40/42]: ppc64: IOMMU: don't ioremap null pointers Linas Vepstas
2005-11-04  0:55 ` [PATCH 41/42]: ppc64: Save device BARS much earlier in the boot sequence Linas Vepstas
2005-11-04 22:14   ` linas
2005-11-04  0:55 ` [PATCH 42/42]: ppc64: get rid of per_cpu counters Linas Vepstas
2005-11-04  0:57 ` [PATCH 11/42]: ppc64: move code to powerpc directory from ppc64 Linas Vepstas
2005-11-04 22:14 ` [PATCH 0/42] PCI Error Recovery for PPC64 and misc device drivers Greg KH
2005-11-05  0:08   ` Paul Mackerras
2005-11-05  0:28     ` Greg KH
2005-11-05  0:46       ` Paul Mackerras
2005-11-05  1:28         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051110002746.GW19593@austin.ibm.com \
    --to=linas@austin.ibm.com \
    --cc=doug@mcnaught.org \
    --cc=jamagallon@able.es \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc64-dev@ozlabs.org \
    --cc=mrmacman_g4@mac.com \
    --cc=rostedt@goodmis.org \
    --cc=vlobanov@speakeasy.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome