* [PATCH] rt11 Fill out default_simple_type
@ 2005-11-12 14:44 Daniel Walker
2005-11-12 14:48 ` Ingo Molnar
0 siblings, 1 reply; 7+ messages in thread
From: Daniel Walker @ 2005-11-12 14:44 UTC (permalink / raw)
To: mingo; +Cc: tglx, trini, sdietrich, linux-kernel
Needed to boot some ARM boards.
Signed-Off-By: Daniel Walker <dwalker@mvista.com>
Index: linux-2.6.14/kernel/irq/handle.c
===================================================================
--- linux-2.6.14.orig/kernel/irq/handle.c
+++ linux-2.6.14/kernel/irq/handle.c
@@ -196,8 +196,9 @@ struct irq_type default_level_type = {
*/
struct irq_type default_simple_type = {
.typename = "default_simple",
- .enable = noop,
- .disable = noop,
+ .enable = default_enable,
+ .disable = default_disable,
+ .set_type = default_set_type,
.handle_irq = handle_simple_irq,
};
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] rt11 Fill out default_simple_type
2005-11-12 14:44 [PATCH] rt11 Fill out default_simple_type Daniel Walker
@ 2005-11-12 14:48 ` Ingo Molnar
2005-11-12 14:52 ` Daniel Walker
2005-11-13 21:56 ` Thomas Gleixner
0 siblings, 2 replies; 7+ messages in thread
From: Ingo Molnar @ 2005-11-12 14:48 UTC (permalink / raw)
To: Daniel Walker; +Cc: tglx, trini, sdietrich, linux-kernel
doesnt apply. Also, the set_type line has whitespace damage.
Ingo
* Daniel Walker <dwalker@mvista.com> wrote:
>
> Needed to boot some ARM boards.
>
> Signed-Off-By: Daniel Walker <dwalker@mvista.com>
>
> Index: linux-2.6.14/kernel/irq/handle.c
> ===================================================================
> --- linux-2.6.14.orig/kernel/irq/handle.c
> +++ linux-2.6.14/kernel/irq/handle.c
> @@ -196,8 +196,9 @@ struct irq_type default_level_type = {
> */
> struct irq_type default_simple_type = {
> .typename = "default_simple",
> - .enable = noop,
> - .disable = noop,
> + .enable = default_enable,
> + .disable = default_disable,
> + .set_type = default_set_type,
> .handle_irq = handle_simple_irq,
> };
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] rt11 Fill out default_simple_type
2005-11-12 14:48 ` Ingo Molnar
@ 2005-11-12 14:52 ` Daniel Walker
2005-11-13 21:56 ` Thomas Gleixner
1 sibling, 0 replies; 7+ messages in thread
From: Daniel Walker @ 2005-11-12 14:52 UTC (permalink / raw)
To: Ingo Molnar; +Cc: tglx, trini, sdietrich, linux-kernel
Teach me not use pine. I'll send it attached privatly, I think it's been
well reviewed anyway .
Daniel
On Sat, 2005-11-12 at 15:48 +0100, Ingo Molnar wrote:
> doesnt apply. Also, the set_type line has whitespace damage.
>
> Ingo
>
> * Daniel Walker <dwalker@mvista.com> wrote:
>
> >
> > Needed to boot some ARM boards.
> >
> > Signed-Off-By: Daniel Walker <dwalker@mvista.com>
> >
> > Index: linux-2.6.14/kernel/irq/handle.c
> > ===================================================================
> > --- linux-2.6.14.orig/kernel/irq/handle.c
> > +++ linux-2.6.14/kernel/irq/handle.c
> > @@ -196,8 +196,9 @@ struct irq_type default_level_type = {
> > */
> > struct irq_type default_simple_type = {
> > .typename = "default_simple",
> > - .enable = noop,
> > - .disable = noop,
> > + .enable = default_enable,
> > + .disable = default_disable,
> > + .set_type = default_set_type,
> > .handle_irq = handle_simple_irq,
> > };
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] rt11 Fill out default_simple_type
2005-11-12 14:48 ` Ingo Molnar
2005-11-12 14:52 ` Daniel Walker
@ 2005-11-13 21:56 ` Thomas Gleixner
2005-11-13 22:11 ` Tom Rini
2005-11-14 18:47 ` Ingo Molnar
1 sibling, 2 replies; 7+ messages in thread
From: Thomas Gleixner @ 2005-11-13 21:56 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Daniel Walker, trini, sdietrich, linux-kernel
On Sat, 2005-11-12 at 15:48 +0100, Ingo Molnar wrote:
> doesnt apply. Also, the set_type line has whitespace damage.
>
> Ingo
I have integrated the initial patch from Tom Rini into the arm generic
irq patch set.
http://www.tglx.de/projects/armirq/
tglx
-------- Forwarded Message --------
From: Tom Rini <trini@kernel.crashing.org>
To: Thomas Gleixner <tglx@linutronix.de>
Subject: Re: ARM genirqs on OMAP
Date: Thu, 10 Nov 2005 10:11:12 -0700
Here it all is. I've been talking with Daniel right now and got it all
trimmed down:
Signed-off-by: Tom Rini <trini@kernel.crashing.org>
Signed-off-by: Daniel Walker <dwalker@mvista.com>
arch/arm/mach-omap1/board-osk.c | 2 +-
arch/arm/plat-omap/gpio.c | 2 +-
kernel/irq/handle.c | 5 +++--
3 files changed, 5 insertions(+), 4 deletions(-)
Index: linux-2.6.14/arch/arm/mach-omap1/board-osk.c
===================================================================
--- linux-2.6.14.orig/arch/arm/mach-omap1/board-osk.c
+++ linux-2.6.14/arch/arm/mach-omap1/board-osk.c
@@ -29,7 +29,7 @@
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/device.h>
-#include <linux/interrupt.h>
+#include <linux/irq.h>
#include <linux/mtd/mtd.h>
#include <linux/mtd/partitions.h>
Index: linux-2.6.14/arch/arm/plat-omap/gpio.c
===================================================================
--- linux-2.6.14.orig/arch/arm/plat-omap/gpio.c
+++ linux-2.6.14/arch/arm/plat-omap/gpio.c
@@ -736,7 +736,7 @@ static void gpio_irq_handler(unsigned in
desc->chip->ack(irq);
- bank = (struct gpio_bank *) desc->data;
+ bank = (struct gpio_bank *) desc->handler_data;
if (bank->method == METHOD_MPUIO)
isr_reg = bank->base + OMAP_MPUIO_GPIO_INT;
#ifdef CONFIG_ARCH_OMAP1510
Index: linux-2.6.14/kernel/irq/handle.c
===================================================================
--- linux-2.6.14.orig/kernel/irq/handle.c
+++ linux-2.6.14/kernel/irq/handle.c
@@ -196,8 +196,9 @@ struct irq_type default_level_type = {
*/
struct irq_type default_simple_type = {
.typename = "default_simple",
- .enable = noop,
- .disable = noop,
+ .enable = default_enable,
+ .disable = default_disable,
+ .set_type = default_set_type,
.handle_irq = handle_simple_irq,
};
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] rt11 Fill out default_simple_type
2005-11-13 21:56 ` Thomas Gleixner
@ 2005-11-13 22:11 ` Tom Rini
2005-11-13 22:17 ` Thomas Gleixner
2005-11-14 18:47 ` Ingo Molnar
1 sibling, 1 reply; 7+ messages in thread
From: Tom Rini @ 2005-11-13 22:11 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: Ingo Molnar, Daniel Walker, sdietrich, linux-kernel
On Sun, Nov 13, 2005 at 10:56:15PM +0100, Thomas Gleixner wrote:
> On Sat, 2005-11-12 at 15:48 +0100, Ingo Molnar wrote:
> > doesnt apply. Also, the set_type line has whitespace damage.
> >
> > Ingo
>
> I have integrated the initial patch from Tom Rini into the arm generic
> irq patch set.
>
> http://www.tglx.de/projects/armirq/
Which was from Daniel of cousre.
--
Tom Rini
http://gate.crashing.org/~trini/
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] rt11 Fill out default_simple_type
2005-11-13 22:11 ` Tom Rini
@ 2005-11-13 22:17 ` Thomas Gleixner
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Gleixner @ 2005-11-13 22:17 UTC (permalink / raw)
To: Tom Rini; +Cc: Ingo Molnar, Daniel Walker, sdietrich, linux-kernel
On Sun, 2005-11-13 at 15:11 -0700, Tom Rini wrote:
> On Sun, Nov 13, 2005 at 10:56:15PM +0100, Thomas Gleixner wrote:
> > On Sat, 2005-11-12 at 15:48 +0100, Ingo Molnar wrote:
> > > doesnt apply. Also, the set_type line has whitespace damage.
> > >
> > > Ingo
> >
> > I have integrated the initial patch from Tom Rini into the arm generic
> > irq patch set.
> >
> > http://www.tglx.de/projects/armirq/
>
> Which was from Daniel of cousre.
Sorry, was not obvious from the mail and Signed-off lines
tglx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] rt11 Fill out default_simple_type
2005-11-13 21:56 ` Thomas Gleixner
2005-11-13 22:11 ` Tom Rini
@ 2005-11-14 18:47 ` Ingo Molnar
1 sibling, 0 replies; 7+ messages in thread
From: Ingo Molnar @ 2005-11-14 18:47 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: Daniel Walker, trini, sdietrich, linux-kernel
* Thomas Gleixner <tglx@linutronix.de> wrote:
> On Sat, 2005-11-12 at 15:48 +0100, Ingo Molnar wrote:
> > doesnt apply. Also, the set_type line has whitespace damage.
> >
> > Ingo
>
> I have integrated the initial patch from Tom Rini into the arm generic
> irq patch set.
this ptach too had whitespace damage (spaces instead of tabs) - merged
it by hand.
Ingo
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2005-11-14 18:47 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-11-12 14:44 [PATCH] rt11 Fill out default_simple_type Daniel Walker
2005-11-12 14:48 ` Ingo Molnar
2005-11-12 14:52 ` Daniel Walker
2005-11-13 21:56 ` Thomas Gleixner
2005-11-13 22:11 ` Tom Rini
2005-11-13 22:17 ` Thomas Gleixner
2005-11-14 18:47 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome