schedule_work in net/*

schedule_work in net/*

[Der Herr Hofrat]

Hi !

 while looking for a posibly work queue related problem i noticed
 that the return value of schedule_work/scheule_delayed_work is not
 checked in the networking code (and in other cases aswell) - is there
 a particular reason for this - or has it just been forgotten ?
 Atleast in the network code it looks like events could be silently
 lost. (net/core/link_watch.c ipv4/inet_timewait_sock.c etc.) 

thx !
hofrat

Re: schedule_work in net/*

[linux-os (Dick Johnson)]

On Tue, 15 Nov 2005, Der Herr Hofrat wrote:

>
> Hi !
>
> while looking for a posibly work queue related problem i noticed
> that the return value of schedule_work/scheule_delayed_work is not
> checked in the networking code (and in other cases aswell) - is there
> a particular reason for this - or has it just been forgotten ?
> Atleast in the network code it looks like events could be silently
> lost. (net/core/link_watch.c ipv4/inet_timewait_sock.c etc.)
>
> thx !
> hofrat

Yes!  Anything inside the IP can be lost. That's how it works in
oper places as well. If the receive queue gets full, packets
are thrown away, etc. It's up to the upper-levels to make
everything work transparently in protocols that require it.

Cheers,
Dick Johnson
Penguin : Linux version 2.6.13.4 on an i686 machine (5589.54 BogoMips).
Warning : 98.36% of all statistics are fiction.
.

****************************************************************
The information transmitted in this message is confidential and may be privileged.  Any review, retransmission, dissemination, or other use of this information by persons or entities other than the intended recipient is prohibited.  If you are not the intended recipient, please notify Analogic Corporation immediately - by replying to this message or by sending an email to DeliveryErrors@analogic.com - and destroy all copies of this information, including any attachments, without reading or disclosing them.

Thank you.