From: Jody McIntyre <scjody@steamballoon.com>
To: Ben Collins <bcollins@debian.org>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
Adrian Bunk <bunk@stusta.de>, Dave Jones <davej@redhat.com>,
dan@dennedy.org, linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [2.6 patch] drivers/ieee1394/raw1394.c: fix a NULL pointer dereference
Date: Mon, 21 Nov 2005 16:52:26 -0500 [thread overview]
Message-ID: <20051121215226.GN20781@conscoop.ottawa.on.ca> (raw)
In-Reply-To: <20051121185609.GB14962@swissdisk.com>
On Mon, Nov 21, 2005 at 10:56:09AM -0800, Ben Collins wrote:
> >
> > This looks OK to me. But there seems to be another bug. I think the line
> >
> > kfree(cache);
> >
> > after the if and else blocks has to be replaced by
> >
> > CSR1212_FREE(cache);
>
> Yes, please. We are trying to keep the csr1212.[ch] files compatible for
> use in userspace and kernel.
raw1394.c does not have to be kept compatible. Stefan's suggestion
doesn't hurt though. Anyone have a patch?
Cheers,
Jody
>
> --
> Ubuntu - http://www.ubuntu.com/
> Debian - http://www.debian.org/
> Linux 1394 - http://www.linux1394.org/
> SwissDisk - http://www.swissdisk.com/
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by the JBoss Inc. Get Certified Today
> Register for a JBoss Training Course. Free Certification Exam
> for All Training Attendees Through End of 2005. For more info visit:
> http://ads.osdn.com/?ad_id=7628&alloc_id=16845&op=click
> _______________________________________________
> mailing list linux1394-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux1394-devel
--
next prev parent reply other threads:[~2005-11-21 21:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-20 23:20 Adrian Bunk
2005-11-20 23:33 ` Jody McIntyre
2005-11-20 23:46 ` Adrian Bunk
2005-11-20 23:54 ` Adrian Bunk
2005-11-20 23:40 ` Dave Jones
2005-11-20 23:52 ` Adrian Bunk
2005-11-21 19:13 ` Stefan Richter
2005-11-21 18:56 ` Ben Collins
2005-11-21 21:52 ` Jody McIntyre [this message]
2005-11-21 22:09 ` Stefan Richter
2005-11-21 22:32 ` Jody McIntyre
2005-11-21 21:55 ` Jody McIntyre
2005-11-20 23:45 ` Jesper Juhl
2005-11-20 23:54 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051121215226.GN20781@conscoop.ottawa.on.ca \
--to=scjody@steamballoon.com \
--cc=bcollins@debian.org \
--cc=bunk@stusta.de \
--cc=dan@dennedy.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stable@kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®