From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: Dave Jones <davej@redhat.com>,
bcollins@debian.org, dan@dennedy.org,
linux1394-devel@lists.sourceforge.net, scjody@steamballoon.com,
linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [2.6 patch] drivers/ieee1394/raw1394.c: fix a NULL pointer dereference
Date: Mon, 21 Nov 2005 20:13:11 +0100 [thread overview]
Message-ID: <43821C47.6010702@s5r6.in-berlin.de> (raw)
In-Reply-To: <20051120235242.GR16060@stusta.de>
Adrian Bunk wrote:
[...]
> There's no need to free cache at this point, and it's getting free'd
> later.
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.15-rc1-mm2-full/drivers/ieee1394/raw1394.c.old 2005-11-20 22:08:57.000000000 +0100
> +++ linux-2.6.15-rc1-mm2-full/drivers/ieee1394/raw1394.c 2005-11-21 00:49:38.000000000 +0100
> @@ -2131,7 +2131,6 @@
> req->req.length)) {
> csr1212_release_keyval(fi->csr1212_dirs[dr]);
> fi->csr1212_dirs[dr] = NULL;
> - CSR1212_FREE(cache);
> ret = -EFAULT;
> } else {
> cache->len = req->req.length;
This looks OK to me. But there seems to be another bug. I think the line
kfree(cache);
after the if and else blocks has to be replaced by
CSR1212_FREE(cache);
--
Stefan Richter
-=====-=-=-= =-== =-=-=
http://arcgraph.de/sr/
next prev parent reply other threads:[~2005-11-21 19:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-20 23:20 Adrian Bunk
2005-11-20 23:33 ` Jody McIntyre
2005-11-20 23:46 ` Adrian Bunk
2005-11-20 23:54 ` Adrian Bunk
2005-11-20 23:40 ` Dave Jones
2005-11-20 23:52 ` Adrian Bunk
2005-11-21 19:13 ` Stefan Richter [this message]
2005-11-21 18:56 ` Ben Collins
2005-11-21 21:52 ` Jody McIntyre
2005-11-21 22:09 ` Stefan Richter
2005-11-21 22:32 ` Jody McIntyre
2005-11-21 21:55 ` Jody McIntyre
2005-11-20 23:45 ` Jesper Juhl
2005-11-20 23:54 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43821C47.6010702@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=bcollins@debian.org \
--cc=bunk@stusta.de \
--cc=dan@dennedy.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=scjody@steamballoon.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®