mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [patch] hdaps: missing an axis.
@ 2005-11-22 15:57 Robert Love
  2005-11-22 20:21 ` Jean Delvare
  0 siblings, 1 reply; 3+ messages in thread
From: Robert Love @ 2005-11-22 15:57 UTC (permalink / raw)
  To: greg; +Cc: lkml


Greg,

Trivial patch to report both hdaps axises to the joystick device, not
just the X axis.

Patch originally by Eugeniy Meshcheryakov <eugen@univ.kiev.ua>.

Signed-off-by: Robert Love <rml@novell.com>

	Robert Love


diff -urN a/drivers/hwmon/hdaps.c b/drivers/hwmon/hdaps.c
--- a/drivers/hwmon/hdaps.c	Wed Nov 16 17:18:55 2005
+++ b/drivers/hwmon/hdaps.c	Tue Nov 22 14:24:25 2005
@@ -570,7 +570,7 @@
 	hdaps_idev->evbit[0] = BIT(EV_ABS);
 	input_set_abs_params(hdaps_idev, ABS_X,
 			-256, 256, HDAPS_INPUT_FUZZ, HDAPS_INPUT_FLAT);
-	input_set_abs_params(hdaps_idev, ABS_X,
+	input_set_abs_params(hdaps_idev, ABS_Y,
 			-256, 256, HDAPS_INPUT_FUZZ, HDAPS_INPUT_FLAT);
 
 	input_register_device(hdaps_idev);



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch] hdaps: missing an axis.
  2005-11-22 15:57 [patch] hdaps: missing an axis Robert Love
@ 2005-11-22 20:21 ` Jean Delvare
  2005-11-22 20:54   ` Robert Love
  0 siblings, 1 reply; 3+ messages in thread
From: Jean Delvare @ 2005-11-22 20:21 UTC (permalink / raw)
  To: Robert Love; +Cc: Greg KH, LKML

Hi Robert,

> Greg,
> 
> Trivial patch to report both hdaps axises to the joystick device, not
> just the X axis.

That would rather be for me. I've enqueued it, thanks.

Looks like a bugfix we want in 2.6.15, right?

-- 
Jean Delvare

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch] hdaps: missing an axis.
  2005-11-22 20:21 ` Jean Delvare
@ 2005-11-22 20:54   ` Robert Love
  0 siblings, 0 replies; 3+ messages in thread
From: Robert Love @ 2005-11-22 20:54 UTC (permalink / raw)
  To: Jean Delvare; +Cc: Greg KH, LKML

On Tue, 2005-11-22 at 21:21 +0100, Jean Delvare wrote:

> That would rather be for me. I've enqueued it, thanks.

Ah, okay.  Thanks.  I did not know there were any driver subsystems that
Greg didn't maintain.

> Looks like a bugfix we want in 2.6.15, right?

It is not critical, but 2.6.15 would be nice.  It is simple enough.

	Robert Love



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-11-22 20:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-11-22 15:57 [patch] hdaps: missing an axis Robert Love
2005-11-22 20:21 ` Jean Delvare
2005-11-22 20:54   ` Robert Love

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®