mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: mousedev parametes not visible in /sys
Date: Sat, 26 Nov 2005 16:17:56 -0500	[thread overview]
Message-ID: <200511261617.57597.dtor_core@ameritech.net> (raw)
In-Reply-To: <Pine.LNX.4.61.0511262102390.17231@yvahk01.tjqt.qr>

On Saturday 26 November 2005 15:08, Jan Engelhardt wrote:
> Hello,
> 
> 
> linux-2.6.13/drivers/input/mousedev.c has some module_params, but they do 
> not show up in /sys, i.e. there is no /sys/modules/mousedev directory at 
> all. Even though it is a compiled-in 'module', I do know that even 
> compiled-ins can get a directory under /sys/modules/, as is the case with 
> a module_param in e.g. drivers/char/vt.c which shows as /sys/modules/vt.
> 
> Can anybody confirm this or know what's wrong?
>

Hi Jan,

They have 0 permission so corresponding attributes are not created.
Something like the patch below shoudl fix that. 

-- 
Dmitry

Input: mousedev - make module parameters visible in sysfs

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---

 drivers/input/mousedev.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

Index: work/drivers/input/mousedev.c
===================================================================
--- work.orig/drivers/input/mousedev.c
+++ work/drivers/input/mousedev.c
@@ -40,15 +40,15 @@ MODULE_LICENSE("GPL");
 #endif
 
 static int xres = CONFIG_INPUT_MOUSEDEV_SCREEN_X;
-module_param(xres, uint, 0);
+module_param(xres, uint, 0644);
 MODULE_PARM_DESC(xres, "Horizontal screen resolution");
 
 static int yres = CONFIG_INPUT_MOUSEDEV_SCREEN_Y;
-module_param(yres, uint, 0);
+module_param(yres, uint, 0644);
 MODULE_PARM_DESC(yres, "Vertical screen resolution");
 
 static unsigned tap_time = 200;
-module_param(tap_time, uint, 0);
+module_param(tap_time, uint, 0644);
 MODULE_PARM_DESC(tap_time, "Tap time for touchpads in absolute mode (msecs)");
 
 struct mousedev_hw_data {

      reply	other threads:[~2005-11-26 21:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-26 20:08 Jan Engelhardt
2005-11-26 21:17 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200511261617.57597.dtor_core@ameritech.net \
    --to=dtor_core@ameritech.net \
    --cc=jengelh@linux01.gwdg.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome