mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* mousedev parametes not visible in /sys
@ 2005-11-26 20:08 Jan Engelhardt
  2005-11-26 21:17 ` Dmitry Torokhov
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Engelhardt @ 2005-11-26 20:08 UTC (permalink / raw)
  To: Linux Kernel Mailing List

Hello,


linux-2.6.13/drivers/input/mousedev.c has some module_params, but they do 
not show up in /sys, i.e. there is no /sys/modules/mousedev directory at 
all. Even though it is a compiled-in 'module', I do know that even 
compiled-ins can get a directory under /sys/modules/, as is the case with 
a module_param in e.g. drivers/char/vt.c which shows as /sys/modules/vt.

Can anybody confirm this or know what's wrong?



Jan Engelhardt
-- 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: mousedev parametes not visible in /sys
  2005-11-26 20:08 mousedev parametes not visible in /sys Jan Engelhardt
@ 2005-11-26 21:17 ` Dmitry Torokhov
  0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2005-11-26 21:17 UTC (permalink / raw)
  To: Jan Engelhardt; +Cc: Linux Kernel Mailing List

On Saturday 26 November 2005 15:08, Jan Engelhardt wrote:
> Hello,
> 
> 
> linux-2.6.13/drivers/input/mousedev.c has some module_params, but they do 
> not show up in /sys, i.e. there is no /sys/modules/mousedev directory at 
> all. Even though it is a compiled-in 'module', I do know that even 
> compiled-ins can get a directory under /sys/modules/, as is the case with 
> a module_param in e.g. drivers/char/vt.c which shows as /sys/modules/vt.
> 
> Can anybody confirm this or know what's wrong?
>

Hi Jan,

They have 0 permission so corresponding attributes are not created.
Something like the patch below shoudl fix that. 

-- 
Dmitry

Input: mousedev - make module parameters visible in sysfs

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---

 drivers/input/mousedev.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

Index: work/drivers/input/mousedev.c
===================================================================
--- work.orig/drivers/input/mousedev.c
+++ work/drivers/input/mousedev.c
@@ -40,15 +40,15 @@ MODULE_LICENSE("GPL");
 #endif
 
 static int xres = CONFIG_INPUT_MOUSEDEV_SCREEN_X;
-module_param(xres, uint, 0);
+module_param(xres, uint, 0644);
 MODULE_PARM_DESC(xres, "Horizontal screen resolution");
 
 static int yres = CONFIG_INPUT_MOUSEDEV_SCREEN_Y;
-module_param(yres, uint, 0);
+module_param(yres, uint, 0644);
 MODULE_PARM_DESC(yres, "Vertical screen resolution");
 
 static unsigned tap_time = 200;
-module_param(tap_time, uint, 0);
+module_param(tap_time, uint, 0644);
 MODULE_PARM_DESC(tap_time, "Tap time for touchpads in absolute mode (msecs)");
 
 struct mousedev_hw_data {

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-11-26 21:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-11-26 20:08 mousedev parametes not visible in /sys Jan Engelhardt
2005-11-26 21:17 ` Dmitry Torokhov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome