RE: [PATCH] Add VT flag to cpuinfo

RE: [PATCH] Add VT flag to cpuinfo

[Dugger, Donald D]

Andi-

As I said, we discussed this internally and the concensus was that
`vmx' was correct.  Especially since this term is used in the
documentation this should be safe.

--
Don Dugger
"Censeo Toto nos in Kansa esse decisse." - D. Gale
Donald.D.Dugger@intel.com
Ph: (303)440-1368 

>-----Original Message-----
>From: Andi Kleen [mailto:ak@suse.de] 
>Sent: Wednesday, November 30, 2005 4:50 PM
>To: Dugger, Donald D
>Cc: Andi Kleen; linux-kernel@vger.kernel.org; Shah, Rajesh; 
>akpm@osdl.org
>Subject: Re: [PATCH] Add VT flag to cpuinfo
>
>On Wed, Nov 30, 2005 at 03:46:09PM -0800, Dugger, Donald D wrote:
>> Andi-
>> 
>> Story of my life (I've had way too many patches that I
>> sent out just a little too late :-)
>
>It might be useful if you could confirm "vmx" is the really
>official name that will continue to be used to describe that feature
>in the future.  We're already stuck with PNI instead of SSE3 and no
>need to make that mistake problem. If VT matches the long term 
>naming better
>it would be a good idea to still rename it.
>
>-Andi
>

RE: Add VT flag to cpuinfo; SSE3 flag

[Jan Engelhardt]

>As I said, we discussed this internally and the concensus was that
>`vmx' was correct.  Especially since this term is used in the
>documentation this should be safe.

If not, I would propose to prefix or postfix the cpuflag somehow, maybe 
coupled with the arch or creator like 'ivmx' (intel vmx) and 'pvmx' (ppc 
vmx).

Oh BTW, I am missing an 'sse3' flag in /proc/cpuinfo on Opterons (running 
2.6.13). Could this be added, if it has not yet in 2.6.15rc*?


Jan Engelhardt
-- 

Re: Add VT flag to cpuinfo; SSE3 flag

[Andi Kleen]

> Oh BTW, I am missing an 'sse3' flag in /proc/cpuinfo on Opterons (running 
> 2.6.13). Could this be added, if it has not yet in 2.6.15rc*?

It's pni for historical reasons.

-Andi

Re: Add VT flag to cpuinfo; SSE3 flag

[Jan Engelhardt]

>> Oh BTW, I am missing an 'sse3' flag in /proc/cpuinfo on Opterons (running 
>> 2.6.13). Could this be added, if it has not yet in 2.6.15rc*?
>
>It's pni for historical reasons.

I could not find pni either. This is all what cpuinfo gives on one:

processor       : 1
vendor_id       : AuthenticAMD
cpu family      : 15
model           : 5
model name      : AMD Opteron(tm) Processor 248
stepping        : 10
cpu MHz         : 2190.310
cache size      : 1024 KB
fpu             : yes
fpu_exception   : yes
cpuid level     : 1
wp              : yes
flags           : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca 
cmov pat pse36 clflush mmx fxsr sse sse2 syscall nx mmxext lm 3dnowext 
3dnow
bogomips        : 4374.52
TLB size        : 1088 4K pages
clflush size    : 64
cache_alignment : 64
address sizes   : 40 bits physical, 48 bits virtual
power management: ts fid vid ttp



Jan Engelhardt
-- 

Re: Add VT flag to cpuinfo; SSE3 flag

[Andi Kleen]

> I could not find pni either. This is all what cpuinfo gives on one:
> 
> processor       : 1
> vendor_id       : AuthenticAMD
> cpu family      : 15
> model           : 5
> model name      : AMD Opteron(tm) Processor 248
> stepping        : 10

Only E stepping or later Opterons have SSE3. Yours is older.

-Andi