From: Denis Vlasenko <vda@ilport.com.ua>
To: Coywolf Qi Hunt <coywolf@gmail.com>
Cc: "linux-os (Dick Johnson)" <linux-os@analogic.com>,
Paul Jackson <pj@sgi.com>,
francis_moreau2000@yahoo.fr, linux-kernel@vger.kernel.org
Subject: Re: Use enum to declare errno values
Date: Fri, 2 Dec 2005 14:07:02 +0200 [thread overview]
Message-ID: <200512021407.02794.vda@ilport.com.ua> (raw)
In-Reply-To: <2cd57c900512020127m5c7ca8e1u@mail.gmail.com>
On Friday 02 December 2005 11:27, Coywolf Qi Hunt wrote:
> 2005/12/2, Denis Vlasenko <vda@ilport.com.ua>:
> > On Thursday 01 December 2005 22:01, linux-os (Dick Johnson) wrote:
> > > On Thu, 24 Nov 2005, Paul Jackson wrote:
> > >
> > > > If errno's were an enum type, what would be the type
> > > > of the return value of a variety of kernel routines
> > > > that now return an int, returning negative errno's on
> > > > error and zero or positive values on success?
> > >
> > > enums are 'integer types', one of the reasons why #defines
> > > which are also 'integer types' are just as useful. If you
> > > want to auto-increment these integer types, then enums are
> > > useful. Otherwise, just use definitions.
> >
> > There is another reason why enums are better than #defines:
>
> This is a reason why enums are worse than #defines.
Why?
> > file.c:
> > ...
> > #include "something_which_eventually_includes_file.h"
> > ...
> > int f(int foo, int bar)
> > {
> > return foo+bar;
> > }
This gets converted to "int f(int 123, int bar)" when foo
is a #define. Do you disagree that it is bad?
--
vda
next prev parent reply other threads:[~2005-12-02 12:07 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-23 13:24 moreau francis
2005-11-23 14:19 ` linux-os (Dick Johnson)
2005-11-23 14:24 ` Denis Vlasenko
2005-11-23 15:00 ` linux-os (Dick Johnson)
2005-11-24 7:19 ` Denis Vlasenko
2005-11-24 7:30 ` Paul Jackson
2005-11-24 7:37 ` Paul Jackson
2005-12-01 20:01 ` linux-os (Dick Johnson)
2005-12-02 6:49 ` Denis Vlasenko
2005-12-02 9:27 ` Coywolf Qi Hunt
2005-12-02 12:07 ` Denis Vlasenko [this message]
2005-12-02 12:18 ` Pekka Enberg
2005-12-02 12:56 ` Coywolf Qi Hunt
2005-12-02 13:20 ` Denis Vlasenko
2005-12-02 13:34 ` Pekka Enberg
2005-12-02 16:02 ` Bill Davidsen
2005-12-02 16:32 ` Coywolf Qi Hunt
2005-12-02 16:56 ` Vadim Lobanov
2005-12-04 13:10 ` Denis Vlasenko
2005-12-02 16:15 ` Bill Davidsen
2005-12-02 17:07 ` Coywolf Qi Hunt
2005-12-02 17:51 ` Steven Rostedt
2005-12-02 18:15 ` Bill Davidsen
2005-12-02 18:30 ` Horst von Brand
2005-11-23 14:27 ` Denis Vlasenko
2005-11-23 14:31 ` Denis Vlasenko
2005-11-23 15:15 ` Alan Cox
2005-11-23 15:44 ` moreau francis
2005-11-23 15:55 ` Nikita Danilov
2005-11-23 16:05 ` moreau francis
2005-11-23 16:24 ` Nikita Danilov
2005-11-23 16:42 ` moreau francis
2005-11-23 16:54 ` Nikita Danilov
2005-11-24 7:22 ` Denis Vlasenko
2005-11-23 17:35 ` Bill Davidsen
2005-11-24 9:43 ` Giuliano Pochini
2005-11-28 23:19 ` Bill Davidsen
2005-11-24 17:11 ` Ben Pfaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200512021407.02794.vda@ilport.com.ua \
--to=vda@ilport.com.ua \
--cc=coywolf@gmail.com \
--cc=francis_moreau2000@yahoo.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-os@analogic.com \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome