From: Bill Davidsen <davidsen@tmr.com>
To: Coywolf Qi Hunt <coywolf@gmail.com>
Cc: Denis Vlasenko <vda@ilport.com.ua>,
"linux-os (Dick Johnson)" <linux-os@analogic.com>,
Paul Jackson <pj@sgi.com>,
francis_moreau2000@yahoo.fr, linux-kernel@vger.kernel.org
Subject: Re: Use enum to declare errno values
Date: Fri, 02 Dec 2005 11:02:36 -0500 [thread overview]
Message-ID: <4390701C.1030803@tmr.com> (raw)
In-Reply-To: <2cd57c900512020456n2f31101k@mail.gmail.com>
Coywolf Qi Hunt wrote:
> 2005/12/2, Pekka Enberg <penberg@cs.helsinki.fi>:
>
>>Hi,
>>
>>2005/12/2, Denis Vlasenko <vda@ilport.com.ua>:
>>
>>>>There is another reason why enums are better than #defines:
>>
>>On 12/2/05, Coywolf Qi Hunt <coywolf@gmail.com> wrote:
>>
>>>This is a reason why enums are worse than #defines.
>>>
>>>Unlike in other languages, C enum is not much useful in practices.
>>>Maybe the designer wanted C to be as fancy as other languages? C
>>>shouldn't have had enum imho. Anyway we don't have any strong motives
>>>to switch to enums.
>>
>>I don't follow your reasoning. The naming collision is a real problem
>>with macros. With enum and const, the compiler can do proper checking
>>with meaningful error messages. Please explain why you think #define
>>is better for Denis' example?
>>
>> Pekka
>>
>
>
> That is a bad bad style. It should be `#define FOO 123' if you have to
> write it.
>
> It's also hard to see what the confusing bar is "if you are looking at
> file.c alone".
>
> enum is worse than typdef. Don't you see why we should use `struct
> task_struct', rather than `task_t'?
>
> Introducing enum alone can't solve the problems from bad macro usage
> habits. Actually, it's not anything wrong with macros, it's
> programers' bad coding style.
Using enum doesn't *solve* problems, it does *allow* type checking, and
*prevent* namespace pollution. Use of typedef allows future changes, if
you use "struct XXX" you're stuck with it.
--
bill davidsen <davidsen@tmr.com>
CTO TMR Associates, Inc
Doing interesting things with small computers since 1979
next prev parent reply other threads:[~2005-12-02 15:50 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-23 13:24 moreau francis
2005-11-23 14:19 ` linux-os (Dick Johnson)
2005-11-23 14:24 ` Denis Vlasenko
2005-11-23 15:00 ` linux-os (Dick Johnson)
2005-11-24 7:19 ` Denis Vlasenko
2005-11-24 7:30 ` Paul Jackson
2005-11-24 7:37 ` Paul Jackson
2005-12-01 20:01 ` linux-os (Dick Johnson)
2005-12-02 6:49 ` Denis Vlasenko
2005-12-02 9:27 ` Coywolf Qi Hunt
2005-12-02 12:07 ` Denis Vlasenko
2005-12-02 12:18 ` Pekka Enberg
2005-12-02 12:56 ` Coywolf Qi Hunt
2005-12-02 13:20 ` Denis Vlasenko
2005-12-02 13:34 ` Pekka Enberg
2005-12-02 16:02 ` Bill Davidsen [this message]
2005-12-02 16:32 ` Coywolf Qi Hunt
2005-12-02 16:56 ` Vadim Lobanov
2005-12-04 13:10 ` Denis Vlasenko
2005-12-02 16:15 ` Bill Davidsen
2005-12-02 17:07 ` Coywolf Qi Hunt
2005-12-02 17:51 ` Steven Rostedt
2005-12-02 18:15 ` Bill Davidsen
2005-12-02 18:30 ` Horst von Brand
2005-11-23 14:27 ` Denis Vlasenko
2005-11-23 14:31 ` Denis Vlasenko
2005-11-23 15:15 ` Alan Cox
2005-11-23 15:44 ` moreau francis
2005-11-23 15:55 ` Nikita Danilov
2005-11-23 16:05 ` moreau francis
2005-11-23 16:24 ` Nikita Danilov
2005-11-23 16:42 ` moreau francis
2005-11-23 16:54 ` Nikita Danilov
2005-11-24 7:22 ` Denis Vlasenko
2005-11-23 17:35 ` Bill Davidsen
2005-11-24 9:43 ` Giuliano Pochini
2005-11-28 23:19 ` Bill Davidsen
2005-11-24 17:11 ` Ben Pfaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4390701C.1030803@tmr.com \
--to=davidsen@tmr.com \
--cc=coywolf@gmail.com \
--cc=francis_moreau2000@yahoo.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-os@analogic.com \
--cc=pj@sgi.com \
--cc=vda@ilport.com.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome