From: Andi Kleen <ak@suse.de>
To: Ravikiran G Thirumalai <kiran@scalex86.org>
Cc: Andrew Morton <akpm@osdl.org>, Andi Kleen <ak@suse.de>,
linux-kernel@vger.kernel.org, discuss@x86-64.org,
zach@vmware.com, shai@scalex86.org, nippung@calsoftinc.com
Subject: Re: [discuss] [patch] x86_64: align and pad x86_64 GDT on page boundary
Date: Thu, 8 Dec 2005 21:15:18 +0100 [thread overview]
Message-ID: <20051208201518.GN11190@wotan.suse.de> (raw)
In-Reply-To: <20051208194232.GC3776@localhost.localdomain>
On Thu, Dec 08, 2005 at 11:42:32AM -0800, Ravikiran G Thirumalai wrote:
>
> - .align L1_CACHE_BYTES
> + /* zero the remaining page */
> + .fill PAGE_SIZE / 8 - GDT_ENTRIES,8,0
> +
> ENTRY(idt_table)
Why can't the IDT not be shared with the GDT page? It should be mostly
read only right and putting r-o data on that page should be ok, right?
> @@ -743,6 +743,13 @@
> };
> DECLARE_WORK(work, do_fork_idle, &c_idle);
>
> + /* allocate memory for gdts of secondary cpus. Hotplug is considered */
> + if (!cpu_gdt_descr[cpu].address &&
> + !(cpu_gdt_descr[cpu].address = get_zeroed_page(GFP_KERNEL))) {
> + printk("Failed to allocate GDT for CPU %d\n", cpu);
> + return 1;
Is this return really correctly handled? Doubtful.
-Andi
next prev parent reply other threads:[~2005-12-08 20:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-08 19:42 Ravikiran G Thirumalai
2005-12-08 20:15 ` Andi Kleen [this message]
2005-12-08 21:55 ` [discuss] " Ravikiran G Thirumalai
2005-12-08 23:09 ` Rohit Seth
2005-12-08 23:11 ` Andi Kleen
2005-12-08 23:26 ` Rohit Seth
2005-12-08 23:26 ` Andi Kleen
2005-12-08 23:45 ` Rohit Seth
2005-12-08 23:43 ` Andi Kleen
2005-12-09 22:19 ` Ravikiran G Thirumalai
2005-12-09 22:57 ` Andi Kleen
2005-12-09 23:01 ` Rohit Seth
2005-12-09 22:59 ` Andi Kleen
2005-12-09 23:46 ` Ravikiran G Thirumalai
2005-12-12 2:34 ` Zwane Mwaikambo
2005-12-12 2:31 ` Andi Kleen
2005-12-12 2:38 ` Zwane Mwaikambo
2005-12-08 23:50 ` Rohit Seth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051208201518.GN11190@wotan.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=discuss@x86-64.org \
--cc=kiran@scalex86.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nippung@calsoftinc.com \
--cc=shai@scalex86.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®