From: "Anand H. Krishnan" <anandhkrishnan@yahoo.co.in>
To: Ashutosh Naik <ashutosh.naik@gmail.com>,
rusty@rustcorp.com.au, linux-kernel@vger.kernel.org,
rth@redhat.com, akpm@osdl.org, Greg KH <greg@kroah.com>
Subject: Re: Fwd: [RFC][PATCH] Prevent overriding of Symbols in the Kernel, avoiding Undefined behaviour
Date: Tue, 13 Dec 2005 01:59:52 -0800 (PST) [thread overview]
Message-ID: <20051213095952.16201.qmail@web8610.mail.in.yahoo.com> (raw)
In-Reply-To: <81083a450512130146j40a3f1ibc87350bdc9a6f11@mail.gmail.com>
Hi,
>
>
> Hi,
> The check for exportsym not being NULL is
> redundant, since
> mod->num_syms will be 0 in that case. The cast is
> also redundant. You
> have two identical failure cases at the bottom.
All true and will be changed.
> your use of index
> is convoluted: do it after relocations.
>
Though rare, we will have the extra overhead of
relocations before we fail the loading of the m
odule [with the advantage of a cleaner code]. I
s that OK ?
Thanks,
Anand
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
parent reply other threads:[~2005-12-13 10:04 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <81083a450512130146j40a3f1ibc87350bdc9a6f11@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051213095952.16201.qmail@web8610.mail.in.yahoo.com \
--to=anandhkrishnan@yahoo.co.in \
--cc=akpm@osdl.org \
--cc=ashutosh.naik@gmail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rth@redhat.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®