mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Re: Fwd: [RFC][PATCH] Prevent overriding of Symbols in the Kernel, avoiding Undefined behaviour
       [not found] <81083a450512130146j40a3f1ibc87350bdc9a6f11@mail.gmail.com>
@ 2005-12-13  9:59 ` Anand H. Krishnan
  0 siblings, 0 replies; only message in thread
From: Anand H. Krishnan @ 2005-12-13  9:59 UTC (permalink / raw)
  To: Ashutosh Naik, rusty, linux-kernel, rth, akpm, Greg KH

Hi,

>
> 
> Hi,
>         The check for exportsym not being NULL is
> redundant, since
> mod->num_syms will be 0 in that case.  The cast is
> also redundant.  You
> have two identical failure cases at the bottom. 

All true and will be changed.

> your use of index
> is convoluted: do it after relocations.
> 

Though rare, we will have the extra overhead of
relocations before we fail the loading of the m
odule [with the advantage of a cleaner code]. I
s that OK ?



Thanks,
Anand



__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-12-13 10:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <81083a450512130146j40a3f1ibc87350bdc9a6f11@mail.gmail.com>
2005-12-13  9:59 ` Fwd: [RFC][PATCH] Prevent overriding of Symbols in the Kernel, avoiding Undefined behaviour Anand H. Krishnan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®