ip_output.c change question

ip_output.c change question

[Jan Engelhardt]

Hello,


what was the reason to remove the EXPORT_SYMBOL(sysctl_ip_default_ttl) in 
http://www.kernel.org/git/?p=linux/kernel/git/davem/net-2.6.16.git;a=blobdiff;h=c934f5316c3bc1362e85029f3978448501028b96;hp=766564cb420760d0d715d75851a8e49496eeaf6b;hb=0742fd53a3774781255bd1e471e7aa2e4a82d5f7;f=net/ipv4/ip_output.c
? ipt_TARPIT uses this variable and relies on it being available.


Jan Engelhardt
-- 
| Alphagate Systems, http://alphagate.hopto.org/
| jengelh's site, http://jengelh.hopto.org/

Re: ip_output.c change question

[Jesper Juhl]

On 12/21/05, Jan Engelhardt <jengelh@linux01.gwdg.de> wrote:
> Hello,
>
>
> what was the reason to remove the EXPORT_SYMBOL(sysctl_ip_default_ttl) in
> http://www.kernel.org/git/?p=linux/kernel/git/davem/net-2.6.16.git;a=blobdiff;h=c934f5316c3bc1362e85029f3978448501028b96;hp=766564cb420760d0d715d75851a8e49496eeaf6b;hb=0742fd53a3774781255bd1e471e7aa2e4a82d5f7;f=net/ipv4/ip_output.c
> ? ipt_TARPIT uses this variable and relies on it being available.
>

I don't know, but a little digging in the git repository found a little info :

The commit :
http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0742fd53a3774781255bd1e471e7aa2e4a82d5f7

Contained this exlanation :

This patch contains the following possible cleanups:
- make needlessly global code static
- #if 0 the following unused global function:
  - xfrm4_state.c: xfrm4_state_fini
- remove the following unneeded EXPORT_SYMBOL's:
  - ip_output.c: ip_finish_output
  - ip_output.c: sysctl_ip_default_ttl
  - fib_frontend.c: ip_dev_find
  - inetpeer.c: inet_peer_idlock
  - ip_options.c: ip_options_compile
  - ip_options.c: ip_options_undo
  - net/core/request_sock.c: sysctl_max_syn_backlog

[Adding Adrian Bunk and David Miller to Cc as they both signed off on
the patch, maybe they can explain]


--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html

Re: ip_output.c change question

[David S. Miller]

From: Jesper Juhl <jesper.juhl@gmail.com>
Date: Wed, 21 Dec 2005 20:35:22 +0100

> [Adding Adrian Bunk and David Miller to Cc as they both signed off on
> the patch, maybe they can explain]

Nothing inside the tree references that symbol.

The tarpit thing is an external netfilter module.