From: Roland Dreier <roland@topspin.com>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org, openib-general@openib.org
Subject: [PATCH][1/6] IB: Keep MAD work completion valid
Date: Fri, 1 Apr 2005 10:23:50 -0800 [thread overview]
Message-ID: <2005411023.BIKgS4OLfFzZN9qI@topspin.com> (raw)
In-Reply-To:
From: Sean Hefty <sean.hefty@intel.com>
Replace the *wc field in ib_mad_recv_wc from pointing to a structure
on the stack to one allocated with the received MAD buffer. This
allows a client to access the *wc field after their receive completion
handler has returned.
Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Signed-off-by: Roland Dreier <roland@topspin.com>
--- linux-export.orig/drivers/infiniband/core/mad.c 2005-03-31 19:07:01.000000000 -0800
+++ linux-export/drivers/infiniband/core/mad.c 2005-04-01 10:08:54.939957801 -0800
@@ -1600,7 +1600,8 @@
DMA_FROM_DEVICE);
/* Setup MAD receive work completion from "normal" work completion */
- recv->header.recv_wc.wc = wc;
+ recv->header.wc = *wc;
+ recv->header.recv_wc.wc = &recv->header.wc;
recv->header.recv_wc.mad_len = sizeof(struct ib_mad);
recv->header.recv_wc.recv_buf.mad = &recv->mad.mad;
recv->header.recv_wc.recv_buf.grh = &recv->grh;
--- linux-export.orig/drivers/infiniband/core/mad_priv.h 2005-03-31 19:07:14.000000000 -0800
+++ linux-export/drivers/infiniband/core/mad_priv.h 2005-04-01 10:08:54.961953027 -0800
@@ -69,6 +69,7 @@
struct ib_mad_private_header {
struct ib_mad_list_head mad_list;
struct ib_mad_recv_wc recv_wc;
+ struct ib_wc wc;
DECLARE_PCI_UNMAP_ADDR(mapping)
} __attribute__ ((packed));
next reply other threads:[~2005-04-01 18:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-01 18:23 Roland Dreier [this message]
2005-04-01 18:23 ` [PATCH][2/6] IB: remove unneeded includes Roland Dreier
2005-04-01 18:23 ` [PATCH][3/6] IB: Fix FMR pool crash Roland Dreier
2005-04-01 18:23 ` [PATCH][4/6] IB: Trivial FMR printk cleanup Roland Dreier
2005-04-01 18:23 ` [PATCH][5/6] IB: Fix user MAD registrations with class 0 Roland Dreier
2005-04-01 18:23 ` [PATCH][6/6] IB: Remove incorrect comments Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2005411023.BIKgS4OLfFzZN9qI@topspin.com \
--to=roland@topspin.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openib-general@openib.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®