From: Roland Dreier <roland@topspin.com>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org, openib-general@openib.org
Subject: [PATCH][6/6] IB: Remove incorrect comments
Date: Fri, 1 Apr 2005 10:23:51 -0800 [thread overview]
Message-ID: <2005411023.sEUedyez566a4lDQ@topspin.com> (raw)
In-Reply-To: <2005411023.Wt2K1CXaZGIHp9sH@topspin.com>
From: Hal Rosenstock <halr@voltaire.com>
Eliminate unneeded and misleading comments
Signed-off-by: Hal Rosenstock <halr@voltaire.com>
Signed-off-by: Roland Dreier <roland@topspin.com>
--- linux-export.orig/drivers/infiniband/core/agent.c 2005-03-31 19:06:48.000000000 -0800
+++ linux-export/drivers/infiniband/core/agent.c 2005-04-01 10:09:02.621290525 -0800
@@ -129,7 +129,6 @@
goto out;
agent_send_wr->mad = mad_priv;
- /* PCI mapping */
gather_list.addr = dma_map_single(mad_agent->device->dma_device,
&mad_priv->mad,
sizeof(mad_priv->mad),
@@ -261,7 +260,6 @@
list_del(&agent_send_wr->send_list);
spin_unlock_irqrestore(&port_priv->send_list_lock, flags);
- /* Unmap PCI */
dma_unmap_single(mad_agent->device->dma_device,
pci_unmap_addr(agent_send_wr, mapping),
sizeof(agent_send_wr->mad->mad),
--- linux-export.orig/drivers/infiniband/core/mad.c 2005-04-01 10:08:56.473624910 -0800
+++ linux-export/drivers/infiniband/core/mad.c 2005-04-01 10:09:02.768258624 -0800
@@ -2283,7 +2283,6 @@
/* Remove from posted receive MAD list */
list_del(&mad_list->list);
- /* Undo PCI mapping */
dma_unmap_single(qp_info->port_priv->device->dma_device,
pci_unmap_addr(&recv->header, mapping),
sizeof(struct ib_mad_private) -
prev parent reply other threads:[~2005-04-01 18:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-01 18:23 [PATCH][1/6] IB: Keep MAD work completion valid Roland Dreier
2005-04-01 18:23 ` [PATCH][2/6] IB: remove unneeded includes Roland Dreier
2005-04-01 18:23 ` [PATCH][3/6] IB: Fix FMR pool crash Roland Dreier
2005-04-01 18:23 ` [PATCH][4/6] IB: Trivial FMR printk cleanup Roland Dreier
2005-04-01 18:23 ` [PATCH][5/6] IB: Fix user MAD registrations with class 0 Roland Dreier
2005-04-01 18:23 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2005411023.sEUedyez566a4lDQ@topspin.com \
--to=roland@topspin.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openib-general@openib.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®