[PATCH 2/3] Remove unnecessary __attribute__ ((packed))

[PATCH 2/3] Remove unnecessary __attribute__ ((packed))

[Jan Blunck]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

Remove the unnecessary __attribute__ ((packed)) since the enum itself is
packed and not the location of it in the structure.

Signed-off-by: Jan Blunck <jblunck@suse.de>

[-- Attachment #2: afs-eliminate-packed-warnings.diff --]
[-- Type: text/plain, Size: 930 bytes --]

 fs/afs/volume.h |    4 +---
 1 files changed, 1 insertion(+), 3 deletions(-)

Index: linux-2.6/fs/afs/volume.h
===================================================================
--- linux-2.6.orig/fs/afs/volume.h
+++ linux-2.6/fs/afs/volume.h
@@ -18,8 +18,6 @@
 #include "kafsasyncd.h"
 #include "cache.h"
 
-#define __packed __attribute__((packed))
-
 typedef enum {
 	AFS_VLUPD_SLEEP,		/* sleeping waiting for update timer to fire */
 	AFS_VLUPD_PENDING,		/* on pending queue */
@@ -115,7 +113,7 @@ struct afs_volume
 	struct cachefs_cookie	*cache;		/* caching cookie */
 #endif
 	afs_volid_t		vid;		/* volume ID */
-	afs_voltype_t __packed	type;		/* type of volume */
+	afs_voltype_t		type;		/* type of volume */
 	char			type_force;	/* force volume type (suppress R/O -> R/W) */
 	unsigned short		nservers;	/* number of server slots filled */
 	unsigned short		rjservers;	/* number of servers discarded due to -ENOMEDIUM */

Re: [PATCH 2/3] Remove unnecessary __attribute__ ((packed))

[David Howells]

Jan Blunck <jblunck@suse.de> wrote:

> Remove the unnecessary __attribute__ ((packed)) since the enum itself is
> packed and not the location of it in the structure.

Fair enough.

David