[PATCH] cs53l32a: kzalloc conversion

[PATCH] cs53l32a: kzalloc conversion

[Panagiotis Issaris]

From: Panagiotis Issaris <takis@issaris.org>

Conversion of kmalloc+memset to kzalloc.

Signed-off-by: Panagiotis Issaris <takis@issaris.org>

---

 drivers/media/video/cs53l32a.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

d27ad6f2f4c46ed0b29034c413cc8f948506fdc6
diff --git a/drivers/media/video/cs53l32a.c b/drivers/media/video/cs53l32a.c
index 780b352..f9e3b8b 100644
--- a/drivers/media/video/cs53l32a.c
+++ b/drivers/media/video/cs53l32a.c
@@ -146,11 +146,10 @@ static int cs53l32a_attach(struct i2c_ad
 	if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
 		return 0;
 
-	client = kmalloc(sizeof(struct i2c_client), GFP_KERNEL);
+	client = kzalloc(sizeof(struct i2c_client), GFP_KERNEL);
 	if (client == 0)
 		return -ENOMEM;
 
-	memset(client, 0, sizeof(struct i2c_client));
 	client->addr = address;
 	client->adapter = adapter;
 	client->driver = &i2c_driver;
-- 
0.99.9.GIT

Re: [PATCH] cs53l32a: kzalloc conversion

[Andrew Morton]

takis@issaris.org (Panagiotis Issaris) wrote:
>
> From: Panagiotis Issaris <takis@issaris.org>
> 
> Conversion of kmalloc+memset to kzalloc.
> 
> Signed-off-by: Panagiotis Issaris <takis@issaris.org>
> 
> ---
> 
>  drivers/media/video/cs53l32a.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> d27ad6f2f4c46ed0b29034c413cc8f948506fdc6
> diff --git a/drivers/media/video/cs53l32a.c b/drivers/media/video/cs53l32a.c
> index 780b352..f9e3b8b 100644
> --- a/drivers/media/video/cs53l32a.c
> +++ b/drivers/media/video/cs53l32a.c
> @@ -146,11 +146,10 @@ static int cs53l32a_attach(struct i2c_ad
>  	if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
>  		return 0;
>  
> -	client = kmalloc(sizeof(struct i2c_client), GFP_KERNEL);
> +	client = kzalloc(sizeof(struct i2c_client), GFP_KERNEL);
>  	if (client == 0)
>  		return -ENOMEM;
>  
> -	memset(client, 0, sizeof(struct i2c_client));
>  	client->addr = address;
>  	client->adapter = adapter;
>  	client->driver = &i2c_driver;

A quick grep shows that there are ~60 kmalloc+memsets under
drivers/media/video.  So I'd prefer that if we're going to do this, we do
it all in one big hit rather than merging a dribble of little patches.

If someone does this, please also remove the typecasts of the
kmalloc/kzalloc return value, such as

drivers/media/video/mxb.c:      mxb = (struct mxb*)kmalloc(sizeof(struct mxb), GFP_KERNEL);

Re: [PATCH] cs53l32a: kzalloc conversion

[Takis]

Hi,

2006/1/5, Andrew Morton <akpm@osdl.org>:
> >  drivers/media/video/cs53l32a.c |    3 +--
> >  1 files changed, 1 insertions(+), 2 deletions(-)
> A quick grep shows that there are ~60 kmalloc+memsets under
> drivers/media/video.  So I'd prefer that if we're going to do this, we do
> it all in one big hit rather than merging a dribble of little patches.
Sure, prepared two patches yesterday night doing the drivers/media and
net/ directories. I've sent the drivers/media patch earlier today and
will review and submit the net/ patch this evening.

With friendly regards,
Takis