From: Andrew Morton <akpm@osdl.org>
To: Eric Sesterhenn / snakebyte <snakebyte@gmx.de>
Cc: linux-kernel@vger.kernel.org, "Protasevich,
Natalie" <Natalie.Protasevich@UNISYS.com>
Subject: Re: [Patch] es7000 broken without acpi
Date: Tue, 3 Jan 2006 15:48:08 -0800 [thread overview]
Message-ID: <20060103154808.5ca0d1a4.akpm@osdl.org> (raw)
In-Reply-To: <1134427819.18385.2.camel@alice>
Eric Sesterhenn / snakebyte <snakebyte@gmx.de> wrote:
>
> hi,
>
> a make randconfig gave me a situation where es7000 was enabled, but acpi wasnt
> ( dont know if this makes sense ), gcc gave me some compiling errors, which the
> following patch fixes. Please cc me as i am not on the list. Thanks.
>
>
I believe that es7000 requires ACPI, so a better fix would be to enforce
that within Kconfig.
Natalie, can you please comment?
>
>
> diff -up linux-2.6.15-rc5-git2/arch/i386/mach-es7000.orig/es7000.h linux-2.6.15-rc5-git2/arch/i386/mach-es7000/es7000.h
> --- linux-2.6.15-rc5-git2/arch/i386/mach-es7000.orig/es7000.h 2005-12-12 23:44:39.000000000 +0100
> +++ linux-2.6.15-rc5-git2/arch/i386/mach-es7000/es7000.h 2005-12-12 23:43:51.000000000 +0100
> @@ -83,6 +83,7 @@ struct es7000_oem_table {
> struct psai psai;
> };
>
> +#if defined(CONFIG_X86_IO_APIC) && defined(CONFIG_ACPI)
> struct acpi_table_sdt {
> unsigned long pa;
> unsigned long count;
> @@ -98,6 +99,7 @@ struct oem_table {
> u32 OEMTableAddr;
> u32 OEMTableSize;
> };
> +#endif
>
> struct mip_reg {
> unsigned long long off_0;
> diff -up linux-2.6.15-rc5-git2/arch/i386/mach-es7000.orig/es7000plat.c linux-2.6.15-rc5-git2/arch/i386/mach-es7000/es7000plat.c
> --- linux-2.6.15-rc5-git2/arch/i386/mach-es7000.orig/es7000plat.c 2005-12-12 23:44:39.000000000 +0100
> +++ linux-2.6.15-rc5-git2/arch/i386/mach-es7000/es7000plat.c 2005-12-12 23:43:20.000000000 +0100
> @@ -92,7 +92,9 @@ setup_unisys(void)
> es7000_plat = ES7000_ZORRO;
> else
> es7000_plat = ES7000_CLASSIC;
> +#if defined(CONFIG_X86_IO_APIC) && defined(CONFIG_ACPI)
> ioapic_renumber_irq = es7000_rename_gsi;
> +#endif
> }
>
> /*
> @@ -160,6 +162,7 @@ parse_unisys_oem (char *oemptr)
> return es7000_plat;
> }
>
> +#if defined(CONFIG_X86_IO_APIC) && defined(CONFIG_ACPI)
> int __init
> find_unisys_acpi_oem_table(unsigned long *oem_addr)
> {
> @@ -212,6 +215,7 @@ find_unisys_acpi_oem_table(unsigned long
> }
> return -1;
> }
> +#endif
>
> static void
> es7000_spin(int n)
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2006-01-03 23:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-12 22:50 Eric Sesterhenn / snakebyte
2006-01-03 23:48 ` Andrew Morton [this message]
2006-01-04 10:05 ` Peter Hagervall
2006-01-04 1:36 Protasevich, Natalie
2006-01-04 1:51 ` Andrew Morton
2006-01-04 2:46 Protasevich, Natalie
2006-01-04 15:05 Protasevich, Natalie
2006-01-04 15:40 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060103154808.5ca0d1a4.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=Natalie.Protasevich@UNISYS.com \
--cc=linux-kernel@vger.kernel.org \
--cc=snakebyte@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome