From: Andrew Morton <akpm@osdl.org>
To: "Protasevich, Natalie" <Natalie.Protasevich@UNISYS.com>
Cc: snakebyte@gmx.de, linux-kernel@vger.kernel.org
Subject: Re: [Patch] es7000 broken without acpi
Date: Tue, 3 Jan 2006 17:51:25 -0800 [thread overview]
Message-ID: <20060103175125.0013fe15.akpm@osdl.org> (raw)
In-Reply-To: <19D0D50E9B1D0A40A9F0323DBFA04ACC023B09AE@USRV-EXCH4.na.uis.unisys.com>
"Protasevich, Natalie" <Natalie.Protasevich@UNISYS.com> wrote:
>
> > Eric Sesterhenn / snakebyte <snakebyte@gmx.de> wrote:
> > >
> > > hi,
> > >
> > > a make randconfig gave me a situation where es7000 was enabled, but
> > > acpi wasnt ( dont know if this makes sense ), gcc gave me some
> > > compiling errors, which the following patch fixes. Please
> > cc me as i am not on the list. Thanks.
> > >
> > >
> >
> > I believe that es7000 requires ACPI, so a better fix would be
> > to enforce that within Kconfig.
> >
> > Natalie, can you please comment?
>
>
> You are correct, Andrew: ES7000 "preferred" mode is ACPI (although it
> runs in MPS as well, which we use for debugging of intermittent ACPI and
> platform problems).
> I have done a similar patch (see
> http://bugzilla.kernel.org/attachment.cgi?id=5771&action=view) against
> 2.6.13, but the one suggested later by Peter Hagervall
> http://www.ussg.iu.edu/hypermail/linux/kernel/0510.3/1302.html was
> actually taking care of the compile problem through Kconfig better,
> since "acpi=off" option is available for our debug/testing purposes
> anyway.
hm, OK. I won't apply anything then - please send me your preferred fix if
you think there's something here which needs fixing. Either way, we should
attempt to make the kernel compile with all possible configs, if only to
keep `make randconfig' testers happy ;)
next prev parent reply other threads:[~2006-01-04 1:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-04 1:36 Protasevich, Natalie
2006-01-04 1:51 ` Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-01-04 15:05 Protasevich, Natalie
2006-01-04 15:40 ` Andi Kleen
2006-01-04 2:46 Protasevich, Natalie
2005-12-12 22:50 Eric Sesterhenn / snakebyte
2006-01-03 23:48 ` Andrew Morton
2006-01-04 10:05 ` Peter Hagervall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060103175125.0013fe15.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=Natalie.Protasevich@UNISYS.com \
--cc=linux-kernel@vger.kernel.org \
--cc=snakebyte@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome