mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jan Spitalnik <lkml@spitalnik.net>
To: linux-kernel@vger.kernel.org
Cc: Pavel Machek <pavel@ucw.cz>
Subject: [PATCH] Disable swsusp on CONFIG_HIGHMEM64
Date: Fri, 06 Jan 2006 19:45:09 +0100	[thread overview]
Message-ID: <200601061945.09466.lkml@spitalnik.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 533 bytes --]

Hello,

suspending to disk is not supported on CONFIG_HIGHMEM64G setups 
(http://suspend2.net/features). Also suspend to ram doesn't work. This patch 
fixes Kconfig to disallow such combination. I'm not 100% sure about the 
ACPI_SLEEP part, as it might be disabling some working setup - but i think 
that s2r and s2d are the only acpi sleeps allowed, no?

Bye,
	spity

PS: I didn't know that this is not supported so I had some nice oops after 
resume (from ram) and s2d didn't resume at all :-)

-- 
Jan Spitalnik
jan@spitalnik.net

[-- Attachment #2: swsusp-vs-higmem64.patch --]
[-- Type: text/x-diff, Size: 1121 bytes --]

diff --exclude=CVS --exclude=.svn -up --new-file --recursive linux-2.6.old/drivers/acpi/Kconfig linux-2.6/drivers/acpi/Kconfig
--- linux-2.6.old/drivers/acpi/Kconfig	2006-01-06 18:58:10.000000000 +0100
+++ linux-2.6/drivers/acpi/Kconfig	2006-01-06 19:07:34.000000000 +0100
@@ -46,7 +46,7 @@ if ACPI
 
 config ACPI_SLEEP
 	bool "Sleep States"
-	depends on X86 && (!SMP || SUSPEND_SMP)
+	depends on X86 && (!SMP || SUSPEND_SMP) && !HIGHMEM64G
 	depends on PM
 	default y
 	---help---
diff --exclude=CVS --exclude=.svn -up --new-file --recursive linux-2.6.old/kernel/power/Kconfig linux-2.6/kernel/power/Kconfig
--- linux-2.6.old/kernel/power/Kconfig	2006-01-06 18:58:28.000000000 +0100
+++ linux-2.6/kernel/power/Kconfig	2006-01-06 19:07:43.000000000 +0100
@@ -38,7 +38,7 @@ config PM_DEBUG
 
 config SOFTWARE_SUSPEND
 	bool "Software Suspend"
-	depends on PM && SWAP && (X86 && (!SMP || SUSPEND_SMP)) || ((FVR || PPC32) && !SMP)
+	depends on PM && SWAP && (X86 && (!SMP || SUSPEND_SMP) && !HIGHMEM64G) || ((FVR || PPC32) && !SMP)
 	---help---
 	  Enable the possibility of suspending the machine.
 	  It doesn't need APM.

             reply	other threads:[~2006-01-06 18:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-06 18:45 Jan Spitalnik [this message]
2006-01-05 23:43 ` Pavel Machek
2006-01-07 15:04   ` Jan Spitalnik
2006-01-06  4:30     ` Pavel Machek
2006-01-07 19:42       ` Jan Spitalnik
2006-01-06 14:23         ` Pavel Machek
2006-01-08 13:34         ` Pavel Machek
2006-01-08 14:16         ` Pavel Machek
2006-01-08 15:52         ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200601061945.09466.lkml@spitalnik.net \
    --to=lkml@spitalnik.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®