mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Pierre Ossman <drzeus@drzeus.cx>
Cc: Pierre Ossman <drzeus-list@drzeus.cx>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [MMC] Lindent wbsd driver
Date: Sun, 8 Jan 2006 14:25:35 +0000	[thread overview]
Message-ID: <20060108142535.GC10927@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20060107231747.29389.80042.stgit@poseidon.drzeus.cx>

On Sun, Jan 08, 2006 at 12:17:48AM +0100, Pierre Ossman wrote:
> @@ -1079,9 +1030,9 @@ static int wbsd_get_ro(struct mmc_host* 
>  }
>  
>  static struct mmc_host_ops wbsd_ops = {
> -	.request	= wbsd_request,
> -	.set_ios	= wbsd_set_ios,
> -	.get_ro		= wbsd_get_ro,
> +	.request = wbsd_request,
> +	.set_ios = wbsd_set_ios,
> +	.get_ro = wbsd_get_ro,

In addition to Alexey's comments, I think this was better before being
"reindented".  If you agree, could you produce a new patch please?

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core

  parent reply	other threads:[~2006-01-08 14:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-07 23:17 Pierre Ossman
2006-01-08  1:28 ` Alexey Dobriyan
2006-01-08 14:25 ` Russell King [this message]
2006-01-08 14:35   ` Pierre Ossman
2006-01-08 17:48     ` Pierre Ossman
2006-01-08 18:20       ` Russell King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060108142535.GC10927@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=drzeus-list@drzeus.cx \
    --cc=drzeus@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome