From: Pierre Ossman <drzeus@drzeus.cx>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Pierre Ossman <drzeus-list@drzeus.cx>,
linux-kernel@vger.kernel.org, adobriyan@gmail.com
Subject: Re: [PATCH] [MMC] Lindent wbsd driver
Date: Sun, 08 Jan 2006 15:35:05 +0100 [thread overview]
Message-ID: <43C12319.2060604@drzeus.cx> (raw)
In-Reply-To: <20060108142535.GC10927@flint.arm.linux.org.uk>
[-- Attachment #1: Type: text/plain, Size: 669 bytes --]
Russell King wrote:
> On Sun, Jan 08, 2006 at 12:17:48AM +0100, Pierre Ossman wrote:
>
>>@@ -1079,9 +1030,9 @@ static int wbsd_get_ro(struct mmc_host*
>> }
>>
>> static struct mmc_host_ops wbsd_ops = {
>>- .request = wbsd_request,
>>- .set_ios = wbsd_set_ios,
>>- .get_ro = wbsd_get_ro,
>>+ .request = wbsd_request,
>>+ .set_ios = wbsd_set_ios,
>>+ .get_ro = wbsd_get_ro,
>
>
> In addition to Alexey's comments, I think this was better before being
> "reindented". If you agree, could you produce a new patch please?
>
I do. I changed what I noticed, but evidently I missed some things. I'll
go over it again and send you a new patch later today.
Rgds
Pierre
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 251 bytes --]
next prev parent reply other threads:[~2006-01-08 14:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-07 23:17 Pierre Ossman
2006-01-08 1:28 ` Alexey Dobriyan
2006-01-08 14:25 ` Russell King
2006-01-08 14:35 ` Pierre Ossman [this message]
2006-01-08 17:48 ` Pierre Ossman
2006-01-08 18:20 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43C12319.2060604@drzeus.cx \
--to=drzeus@drzeus.cx \
--cc=adobriyan@gmail.com \
--cc=drzeus-list@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome