mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Re: [XFS] Do not inherit properties for the quota inodes from the root inode.
       [not found] <200601121815.k0CIFYBU024320@hera.kernel.org>
@ 2006-01-12 20:43 ` Chris Wedgwood
  2006-01-12 21:15   ` Nathan Scott
  0 siblings, 1 reply; 2+ messages in thread
From: Chris Wedgwood @ 2006-01-12 20:43 UTC (permalink / raw)
  To: Linux Kernel Mailing List

On Thu, Jan 12, 2006 at 10:15:34AM -0800, Linux Kernel Mailing List wrote:
> tree 589ad79019067e1b82006bacf6c10d1d717a46dc
> parent 4ef19dddbaf2f24e492c18112fd8a04ce116daca
> author Nathan Scott <nathans@sgi.com> Wed, 11 Jan 2006 15:27:50 +1100
> committer Nathan Scott <nathans@sgi.com> Wed, 11 Jan 2006 15:27:50 +1100
>
> [XFS] Do not inherit properties for the quota inodes from the root inode.

lots of whitespace changes... :)

>
> -	if ((error = xfs_dir_ialloc(&tp, mp->m_rootip, S_IFREG, 1, 0,
> +	if ((error = xfs_dir_ialloc(&tp, &zeroino, S_IFREG, 1, 0,
>  				   &zerocr, 0, 1, ip, &committed))) {
>  		xfs_trans_cancel(tp, XFS_TRANS_RELEASE_LOG_RES |
>  				 XFS_TRANS_ABORT);

why would you want to do this at all?


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [XFS] Do not inherit properties for the quota inodes from the root inode.
  2006-01-12 20:43 ` [XFS] Do not inherit properties for the quota inodes from the root inode Chris Wedgwood
@ 2006-01-12 21:15   ` Nathan Scott
  0 siblings, 0 replies; 2+ messages in thread
From: Nathan Scott @ 2006-01-12 21:15 UTC (permalink / raw)
  To: Chris Wedgwood; +Cc: Linux Kernel Mailing List

Hi Chris,

On Thu, Jan 12, 2006 at 12:43:36PM -0800, Chris Wedgwood wrote:
> > [XFS] Do not inherit properties for the quota inodes from the root inode.
> 
> lots of whitespace changes... :)

If by "lots" you mean "one line", then yes!

> >
> > -	if ((error = xfs_dir_ialloc(&tp, mp->m_rootip, S_IFREG, 1, 0,
> > +	if ((error = xfs_dir_ialloc(&tp, &zeroino, S_IFREG, 1, 0,
> >  				   &zerocr, 0, 1, ip, &committed))) {
> >  		xfs_trans_cancel(tp, XFS_TRANS_RELEASE_LOG_RES |
> >  				 XFS_TRANS_ABORT);
> 
> why would you want to do this at all?

I'm not sure what you're asking?  There are things we do not
want to inherit from the root inode (certain inode flags in
particular) when the quota inodes are being created... does
that help?

cheers.

-- 
Nathan

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-01-12 21:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <200601121815.k0CIFYBU024320@hera.kernel.org>
2006-01-12 20:43 ` [XFS] Do not inherit properties for the quota inodes from the root inode Chris Wedgwood
2006-01-12 21:15   ` Nathan Scott

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®