mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 2/5] stack overflow safe kdump (2.6.15-i386) - use_safe_smp_processor_id
@ 2006-01-16 13:23 Fernando Luis Vazquez Cao
  2006-01-20 13:22 ` Vivek Goyal
  0 siblings, 1 reply; 2+ messages in thread
From: Fernando Luis Vazquez Cao @ 2006-01-16 13:23 UTC (permalink / raw)
  To: Eric W. Biederman; +Cc: ak, vgoyal, linux-kernel, fastboot

Substitute "smp_processor_id" with the stack overflow-safe
"safe_smp_processor_id" in the reboot path to the second kernel.

---
diff -urNp linux-2.6.15/arch/i386/kernel/crash.c
linux-2.6.15-sov/arch/i386/kernel/crash.c
--- linux-2.6.15/arch/i386/kernel/crash.c	2006-01-03 12:21:10.000000000
+0900
+++ linux-2.6.15-sov/arch/i386/kernel/crash.c	2006-01-16
20:28:31.000000000 +0900
@@ -120,7 +120,7 @@ static void crash_save_self(struct pt_re
 	struct pt_regs regs;
 	int cpu;
 
-	cpu = smp_processor_id();
+	cpu = safe_smp_processor_id();
 	if (saved_regs)
 		crash_setup_regs(&regs, saved_regs);
 	else
@@ -211,7 +211,7 @@ void machine_crash_shutdown(struct pt_re
 	local_irq_disable();
 
 	/* Make a note of crashing cpu. Will be used in NMI callback.*/
-	crashing_cpu = smp_processor_id();
+	crashing_cpu = safe_smp_processor_id();
 	nmi_shootdown_cpus();
 	lapic_shutdown();
 #if defined(CONFIG_X86_IO_APIC)



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/5] stack overflow safe kdump (2.6.15-i386) - use_safe_smp_processor_id
  2006-01-16 13:23 [PATCH 2/5] stack overflow safe kdump (2.6.15-i386) - use_safe_smp_processor_id Fernando Luis Vazquez Cao
@ 2006-01-20 13:22 ` Vivek Goyal
  0 siblings, 0 replies; 2+ messages in thread
From: Vivek Goyal @ 2006-01-20 13:22 UTC (permalink / raw)
  To: Morton Andrew Morton
  Cc: Eric W. Biederman, ak, linux-kernel, fastboot, Fernando Luis Vazquez Cao

On Mon, Jan 16, 2006 at 10:23:53PM +0900, Fernando Luis Vazquez Cao wrote:
> Substitute "smp_processor_id" with the stack overflow-safe
> "safe_smp_processor_id" in the reboot path to the second kernel.
> 

Acked-by: Vivek Goyal <vgoyal@in.ibm.com>

> ---
> diff -urNp linux-2.6.15/arch/i386/kernel/crash.c
> linux-2.6.15-sov/arch/i386/kernel/crash.c
> --- linux-2.6.15/arch/i386/kernel/crash.c	2006-01-03 12:21:10.000000000
> +0900
> +++ linux-2.6.15-sov/arch/i386/kernel/crash.c	2006-01-16
> 20:28:31.000000000 +0900
> @@ -120,7 +120,7 @@ static void crash_save_self(struct pt_re
>  	struct pt_regs regs;
>  	int cpu;
>  
> -	cpu = smp_processor_id();
> +	cpu = safe_smp_processor_id();
>  	if (saved_regs)
>  		crash_setup_regs(&regs, saved_regs);
>  	else
> @@ -211,7 +211,7 @@ void machine_crash_shutdown(struct pt_re
>  	local_irq_disable();
>  
>  	/* Make a note of crashing cpu. Will be used in NMI callback.*/
> -	crashing_cpu = smp_processor_id();
> +	crashing_cpu = safe_smp_processor_id();
>  	nmi_shootdown_cpus();
>  	lapic_shutdown();
>  #if defined(CONFIG_X86_IO_APIC)
> 
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-01-20 13:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-01-16 13:23 [PATCH 2/5] stack overflow safe kdump (2.6.15-i386) - use_safe_smp_processor_id Fernando Luis Vazquez Cao
2006-01-20 13:22 ` Vivek Goyal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome