From: Pete Zaitcev <zaitcev@redhat.com>
To: Guennadi Liakhovetski <gl@dsa-ac.de>
Cc: linux-kernel@vger.kernel.org,
linux-usb-devel@lists.sourceforge.net,
marcelo.tosatti@cyclades.com, zaitcev@redhat.com
Subject: Re: [PATCH 2.4.32] usb-uhci.c failing "-"
Date: Fri, 20 Jan 2006 15:10:30 -0800 [thread overview]
Message-ID: <20060120151030.433abdf6.zaitcev@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.63.0601200928480.1049@pcgl.dsa-ac.de>
On Fri, 20 Jan 2006 09:33:26 +0100 (CET), Guennadi Liakhovetski <gl@dsa-ac.de> wrote:
> Looks like a bug?
> --- a/drivers/usb/host/usb-uhci.c Fri Jan 20 09:27:50 2006
> +++ b/drivers/usb/host/usb-uhci.c Fri Jan 20 09:28:05 2006
> @@ -2505,7 +2505,7 @@
> ((urb_priv_t*)urb->hcpriv)->flags=0;
> }
>
> - if ((urb->status != -ECONNABORTED) && (urb->status != ECONNRESET) &&
> + if ((urb->status != -ECONNABORTED) && (urb->status != -ECONNRESET) &&
> (urb->status != -ENOENT)) {
This is not what the author intended, obviously. But I am not quite sure
what happens because of it. Seems like we unlink some things which are
about to return anyway... and then return -104 instead of -84. This
may be relatively harmless. At worst, the driver resubmits and gets
its -84 that way.
I vote to apply this and see what happens. We are early in 2.4.33 cycle,
so it should be safe.
-- Pete
next prev parent reply other threads:[~2006-01-20 23:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-20 8:33 Guennadi Liakhovetski
2006-01-20 22:19 ` Willy Tarreau
2006-01-20 23:10 ` Pete Zaitcev [this message]
2006-01-22 0:15 ` Guennadi Liakhovetski
2006-01-22 7:27 ` Pete Zaitcev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060120151030.433abdf6.zaitcev@redhat.com \
--to=zaitcev@redhat.com \
--cc=gl@dsa-ac.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome