From: Pete Zaitcev <zaitcev@redhat.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: gl@dsa-ac.de, linux-kernel@vger.kernel.org,
linux-usb-devel@lists.sourceforge.net,
marcelo.tosatti@cyclades.com, zaitcev@redhat.com
Subject: Re: [PATCH 2.4.32] usb-uhci.c failing "-"
Date: Sat, 21 Jan 2006 23:27:21 -0800 [thread overview]
Message-ID: <20060121232721.60c09eed.zaitcev@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.60.0601212230210.9393@poirot.grange>
On Sun, 22 Jan 2006 01:15:23 +0100 (CET), Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:
> i.e., if (!urb->completion) urb->status is not set, so, depending on
> whether the urb has ->completion either the old or the new status will be
> tested. Is this really correct? And a couple lines above that "goto
> recycle;" is superfluous...
I would not recommend to get too excercised over uhci-hcd in 2.4.32.
I do not with to touch it, because it mostly works, and the risk of
regressions is too great.
-- Pete
prev parent reply other threads:[~2006-01-22 7:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-20 8:33 Guennadi Liakhovetski
2006-01-20 22:19 ` Willy Tarreau
2006-01-20 23:10 ` Pete Zaitcev
2006-01-22 0:15 ` Guennadi Liakhovetski
2006-01-22 7:27 ` Pete Zaitcev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060121232721.60c09eed.zaitcev@redhat.com \
--to=zaitcev@redhat.com \
--cc=g.liakhovetski@gmx.de \
--cc=gl@dsa-ac.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome