From: Ingo Molnar <mingo@elte.hu>
To: Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.15-rt6: network driver disabled interrupts: skge_xmit_frame
Date: Fri, 20 Jan 2006 20:24:22 +0100 [thread overview]
Message-ID: <20060120192422.GA12856@elte.hu> (raw)
In-Reply-To: <1137781510.18253.3.camel@cmn3.stanford.edu>
* Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU> wrote:
> Tons of these messages when I try out the skge network driver under
> 2.6.15-rt6 (instead of the sk98lin driver):
>
> network driver disabled interrupts: skge_xmit_frame+0x0/0x330 [skge]
>
> Any fixes I could try?
could you try the one below ontop of -rt8?
Ingo
Index: linux-rt.q/drivers/net/skge.c
===================================================================
--- linux-rt.q.orig/drivers/net/skge.c
+++ linux-rt.q/drivers/net/skge.c
@@ -2272,12 +2272,9 @@ static int skge_xmit_frame(struct sk_buf
if (!skb)
return NETDEV_TX_OK;
- local_irq_save(flags);
- if (!spin_trylock(&skge->tx_lock)) {
+ if (!spin_trylock_irqsave(&skge->tx_lock))
/* Collision - tell upper layer to requeue */
- local_irq_restore(flags);
return NETDEV_TX_LOCKED;
- }
if (unlikely(skge->tx_avail < skb_shinfo(skb)->nr_frags +1)) {
if (!netif_queue_stopped(dev)) {
prev parent reply other threads:[~2006-01-20 19:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-20 18:25 Fernando Lopez-Lezcano
2006-01-20 19:24 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060120192422.GA12856@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=nando@ccrma.Stanford.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®