* 2.6.15-rt6: network driver disabled interrupts: skge_xmit_frame
@ 2006-01-20 18:25 Fernando Lopez-Lezcano
2006-01-20 19:24 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Fernando Lopez-Lezcano @ 2006-01-20 18:25 UTC (permalink / raw)
To: Ingo Molnar, linux-kernel; +Cc: nando
Tons of these messages when I try out the skge network driver under
2.6.15-rt6 (instead of the sk98lin driver):
network driver disabled interrupts: skge_xmit_frame+0x0/0x330 [skge]
Any fixes I could try?
Thanks...
-- Fernando
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: 2.6.15-rt6: network driver disabled interrupts: skge_xmit_frame
2006-01-20 18:25 2.6.15-rt6: network driver disabled interrupts: skge_xmit_frame Fernando Lopez-Lezcano
@ 2006-01-20 19:24 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2006-01-20 19:24 UTC (permalink / raw)
To: Fernando Lopez-Lezcano; +Cc: linux-kernel
* Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU> wrote:
> Tons of these messages when I try out the skge network driver under
> 2.6.15-rt6 (instead of the sk98lin driver):
>
> network driver disabled interrupts: skge_xmit_frame+0x0/0x330 [skge]
>
> Any fixes I could try?
could you try the one below ontop of -rt8?
Ingo
Index: linux-rt.q/drivers/net/skge.c
===================================================================
--- linux-rt.q.orig/drivers/net/skge.c
+++ linux-rt.q/drivers/net/skge.c
@@ -2272,12 +2272,9 @@ static int skge_xmit_frame(struct sk_buf
if (!skb)
return NETDEV_TX_OK;
- local_irq_save(flags);
- if (!spin_trylock(&skge->tx_lock)) {
+ if (!spin_trylock_irqsave(&skge->tx_lock))
/* Collision - tell upper layer to requeue */
- local_irq_restore(flags);
return NETDEV_TX_LOCKED;
- }
if (unlikely(skge->tx_avail < skb_shinfo(skb)->nr_frags +1)) {
if (!netif_queue_stopped(dev)) {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-01-20 19:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-01-20 18:25 2.6.15-rt6: network driver disabled interrupts: skge_xmit_frame Fernando Lopez-Lezcano
2006-01-20 19:24 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®