* [PATCH] USB: Disable clock for MPH ports not in use on Freescale EHCI
@ 2006-01-23 22:08 Kumar Gala
2006-01-24 16:11 ` [linux-usb-devel] " David Brownell
0 siblings, 1 reply; 2+ messages in thread
From: Kumar Gala @ 2006-01-23 22:08 UTC (permalink / raw)
To: dbrownell; +Cc: Randy Vinson, linux-kernel, linux-usb-devel
In some systems using the Freescale EHCI controller if only one port
of the multiport host (MPH) is being used the other port must be
disabled if there is no clock signal. Since we dont know how someone
will wire a board, we disable the clock if the port is not enabled.
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
commit 984d42232fd47ddbeef7c825ec2bafbca9aed5a0
tree 166532f0cd229b1a6f090c43b3617fd49ff3068a
parent 2497a5e4242d500178d6d0f0ce4ee9249a38f5dc
author Kumar Gala <galak@kernel.crashing.org> Mon, 23 Jan 2006 16:13:21 -0600
committer Kumar Gala <galak@kernel.crashing.org> Mon, 23 Jan 2006 16:13:21 -0600
drivers/usb/host/ehci-fsl.c | 7 +++++++
drivers/usb/host/ehci-fsl.h | 1 +
2 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
index f40ee41..032fa6b 100644
--- a/drivers/usb/host/ehci-fsl.c
+++ b/drivers/usb/host/ehci-fsl.c
@@ -161,6 +161,7 @@ static void mpc83xx_setup_phy(struct ehc
unsigned int port_offset)
{
u32 portsc = 0;
+
switch (phy_mode) {
case FSL_USB2_PHY_ULPI:
portsc |= PORT_PTS_ULPI;
@@ -175,6 +176,7 @@ static void mpc83xx_setup_phy(struct ehc
portsc |= PORT_PTS_UTMI;
break;
case FSL_USB2_PHY_NONE:
+ portsc |= PORT_PHCD;
break;
}
writel(portsc, &ehci->regs->port_status[port_offset]);
@@ -209,8 +211,13 @@ static void mpc83xx_usb_setup(struct usb
if (pdata->port_enables & FSL_USB2_PORT0_ENABLED)
mpc83xx_setup_phy(ehci, pdata->phy_mode, 0);
+ else
+ mpc83xx_setup_phy(ehci, FSL_USB2_PHY_NONE, 0);
+
if (pdata->port_enables & FSL_USB2_PORT1_ENABLED)
mpc83xx_setup_phy(ehci, pdata->phy_mode, 1);
+ else
+ mpc83xx_setup_phy(ehci, FSL_USB2_PHY_NONE, 1);
}
/* put controller in host mode. */
diff --git a/drivers/usb/host/ehci-fsl.h b/drivers/usb/host/ehci-fsl.h
index caac0d1..f579254 100644
--- a/drivers/usb/host/ehci-fsl.h
+++ b/drivers/usb/host/ehci-fsl.h
@@ -26,6 +26,7 @@
#define PORT_PTS_ULPI (2<<30)
#define PORT_PTS_SERIAL (3<<30)
#define PORT_PTS_PTW (1<<28)
+#define PORT_PHCD (1<<23)
#define FSL_SOC_USB_PORTSC2 0x188
#define FSL_SOC_USB_USBMODE 0x1a8
#define FSL_SOC_USB_SNOOP1 0x400 /* NOTE: big-endian */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [linux-usb-devel] [PATCH] USB: Disable clock for MPH ports not in use on Freescale EHCI
2006-01-23 22:08 [PATCH] USB: Disable clock for MPH ports not in use on Freescale EHCI Kumar Gala
@ 2006-01-24 16:11 ` David Brownell
0 siblings, 0 replies; 2+ messages in thread
From: David Brownell @ 2006-01-24 16:11 UTC (permalink / raw)
To: linux-usb-devel; +Cc: Kumar Gala, dbrownell, Randy Vinson, linux-kernel
On Monday 23 January 2006 2:08 pm, Kumar Gala wrote:
> In some systems using the Freescale EHCI controller if only one port
> of the multiport host (MPH) is being used the other port must be
> disabled if there is no clock signal. Since we dont know how someone
> will wire a board, we disable the clock if the port is not enabled.
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Acked-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
> commit 984d42232fd47ddbeef7c825ec2bafbca9aed5a0
> tree 166532f0cd229b1a6f090c43b3617fd49ff3068a
> parent 2497a5e4242d500178d6d0f0ce4ee9249a38f5dc
> author Kumar Gala <galak@kernel.crashing.org> Mon, 23 Jan 2006 16:13:21 -0600
> committer Kumar Gala <galak@kernel.crashing.org> Mon, 23 Jan 2006 16:13:21 -0600
>
> drivers/usb/host/ehci-fsl.c | 7 +++++++
> drivers/usb/host/ehci-fsl.h | 1 +
> 2 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
> index f40ee41..032fa6b 100644
> --- a/drivers/usb/host/ehci-fsl.c
> +++ b/drivers/usb/host/ehci-fsl.c
> @@ -161,6 +161,7 @@ static void mpc83xx_setup_phy(struct ehc
> unsigned int port_offset)
> {
> u32 portsc = 0;
> +
> switch (phy_mode) {
> case FSL_USB2_PHY_ULPI:
> portsc |= PORT_PTS_ULPI;
> @@ -175,6 +176,7 @@ static void mpc83xx_setup_phy(struct ehc
> portsc |= PORT_PTS_UTMI;
> break;
> case FSL_USB2_PHY_NONE:
> + portsc |= PORT_PHCD;
> break;
> }
> writel(portsc, &ehci->regs->port_status[port_offset]);
> @@ -209,8 +211,13 @@ static void mpc83xx_usb_setup(struct usb
>
> if (pdata->port_enables & FSL_USB2_PORT0_ENABLED)
> mpc83xx_setup_phy(ehci, pdata->phy_mode, 0);
> + else
> + mpc83xx_setup_phy(ehci, FSL_USB2_PHY_NONE, 0);
> +
> if (pdata->port_enables & FSL_USB2_PORT1_ENABLED)
> mpc83xx_setup_phy(ehci, pdata->phy_mode, 1);
> + else
> + mpc83xx_setup_phy(ehci, FSL_USB2_PHY_NONE, 1);
> }
>
> /* put controller in host mode. */
> diff --git a/drivers/usb/host/ehci-fsl.h b/drivers/usb/host/ehci-fsl.h
> index caac0d1..f579254 100644
> --- a/drivers/usb/host/ehci-fsl.h
> +++ b/drivers/usb/host/ehci-fsl.h
> @@ -26,6 +26,7 @@
> #define PORT_PTS_ULPI (2<<30)
> #define PORT_PTS_SERIAL (3<<30)
> #define PORT_PTS_PTW (1<<28)
> +#define PORT_PHCD (1<<23)
> #define FSL_SOC_USB_PORTSC2 0x188
> #define FSL_SOC_USB_USBMODE 0x1a8
> #define FSL_SOC_USB_SNOOP1 0x400 /* NOTE: big-endian */
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-01-24 16:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-01-23 22:08 [PATCH] USB: Disable clock for MPH ports not in use on Freescale EHCI Kumar Gala
2006-01-24 16:11 ` [linux-usb-devel] " David Brownell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome