* Re: + update-mm-acx-driver-to-version-0331.patch added to -mm tree
[not found] <200602010211.k112BVps013714@shell0.pdx.osdl.net>
@ 2006-02-01 5:28 ` Arjan van de Ven
2006-02-01 7:07 ` Denis Vlasenko
0 siblings, 1 reply; 2+ messages in thread
From: Arjan van de Ven @ 2006-02-01 5:28 UTC (permalink / raw)
To: linux-kernel; +Cc: vda, akpm
> -struct wlandevice {
> +struct acx_device {
> + /* most frequent accesses first (dereferencing and cache line!) */
> +
> + /*** Locking ***/
> + struct semaphore sem;
> + spinlock_t lock;
> +#if defined(PARANOID_LOCKING) /* Lock debugging */
> + const char *last_sem;
> + const char *last_lock;
> + unsigned long sem_time;
> + unsigned long lock_time;
> +#endif
> +
any chance of turning this into a mutex instead?
(and you get some of the debugging for free instead that way)
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: + update-mm-acx-driver-to-version-0331.patch added to -mm tree
2006-02-01 5:28 ` + update-mm-acx-driver-to-version-0331.patch added to -mm tree Arjan van de Ven
@ 2006-02-01 7:07 ` Denis Vlasenko
0 siblings, 0 replies; 2+ messages in thread
From: Denis Vlasenko @ 2006-02-01 7:07 UTC (permalink / raw)
To: Arjan van de Ven; +Cc: linux-kernel, akpm
On Wednesday 01 February 2006 07:28, Arjan van de Ven wrote:
>
> > -struct wlandevice {
> > +struct acx_device {
> > + /* most frequent accesses first (dereferencing and cache line!) */
> > +
> > + /*** Locking ***/
> > + struct semaphore sem;
> > + spinlock_t lock;
> > +#if defined(PARANOID_LOCKING) /* Lock debugging */
> > + const char *last_sem;
> > + const char *last_lock;
> > + unsigned long sem_time;
> > + unsigned long lock_time;
> > +#endif
> > +
>
> any chance of turning this into a mutex instead?
> (and you get some of the debugging for free instead that way)
(/me is reading Ingo's docs...)
Nice :)
Yes, we will do the conversion later. For now we want our driver
usable on vanilla 2.6.10.
--
vda
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-02-01 7:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <200602010211.k112BVps013714@shell0.pdx.osdl.net>
2006-02-01 5:28 ` + update-mm-acx-driver-to-version-0331.patch added to -mm tree Arjan van de Ven
2006-02-01 7:07 ` Denis Vlasenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome