* [PATCH] sysctl initialization of zone_reclaim_mode
@ 2006-02-01 17:55 Stephen Hemminger
2006-02-01 18:05 ` Linus Torvalds
2006-02-01 18:31 ` Christoph Lameter
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Hemminger @ 2006-02-01 17:55 UTC (permalink / raw)
To: Linus Torvalds, Andrew Morton; +Cc: Andi Kleen, linux-kernel
Fix warning about initialization of sysctl table in current 2.6.16-rc1
git tree. It could cause a nasty if anyone wrote to it.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
--- linux-2.6.orig/kernel/sysctl.c
+++ linux-2.6/kernel/sysctl.c
@@ -878,7 +878,8 @@ static ctl_table vm_table[] = {
.maxlen = sizeof(zone_reclaim_mode),
.mode = 0644,
.proc_handler = &proc_dointvec,
- .strategy = &zero,
+ .strategy = &sysctl_intvec,
+ .extra1 = &zero,
},
#endif
{ .ctl_name = 0 }
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] sysctl initialization of zone_reclaim_mode
2006-02-01 17:55 [PATCH] sysctl initialization of zone_reclaim_mode Stephen Hemminger
@ 2006-02-01 18:05 ` Linus Torvalds
2006-02-01 18:31 ` Christoph Lameter
1 sibling, 0 replies; 3+ messages in thread
From: Linus Torvalds @ 2006-02-01 18:05 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Andrew Morton, Andi Kleen, linux-kernel
On Wed, 1 Feb 2006, Stephen Hemminger wrote:
>
> Fix warning about initialization of sysctl table in current 2.6.16-rc1
> git tree. It could cause a nasty if anyone wrote to it.
Already fixed in the current tree by Christoph Lameter,
Linus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sysctl initialization of zone_reclaim_mode
2006-02-01 17:55 [PATCH] sysctl initialization of zone_reclaim_mode Stephen Hemminger
2006-02-01 18:05 ` Linus Torvalds
@ 2006-02-01 18:31 ` Christoph Lameter
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Lameter @ 2006-02-01 18:31 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Linus Torvalds, Andrew Morton, Andi Kleen, linux-kernel
A cleanup patch has been in Andrews tree for awhile and I hope that Linus
applies it today. This is the ., hmm .... 4th time the patch was posted.
On Wed, 1 Feb 2006, Stephen Hemminger wrote:
> Fix warning about initialization of sysctl table in current 2.6.16-rc1
> git tree. It could cause a nasty if anyone wrote to it.
>
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
>
> --- linux-2.6.orig/kernel/sysctl.c
> +++ linux-2.6/kernel/sysctl.c
> @@ -878,7 +878,8 @@ static ctl_table vm_table[] = {
> .maxlen = sizeof(zone_reclaim_mode),
> .mode = 0644,
> .proc_handler = &proc_dointvec,
> - .strategy = &zero,
> + .strategy = &sysctl_intvec,
> + .extra1 = &zero,
> },
> #endif
> { .ctl_name = 0 }
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-02-01 18:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-02-01 17:55 [PATCH] sysctl initialization of zone_reclaim_mode Stephen Hemminger
2006-02-01 18:05 ` Linus Torvalds
2006-02-01 18:31 ` Christoph Lameter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®