From: Karsten Keil <kkeil@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>
Subject: Re: ISDN warning
Date: Wed, 1 Feb 2006 12:51:34 +0100 [thread overview]
Message-ID: <20060201115134.GA8219@pingi.kke.suse.de> (raw)
In-Reply-To: <20060201010406.05f55c09.akpm@osdl.org>
On Wed, Feb 01, 2006 at 01:04:06AM -0800, Andrew Morton wrote:
>
> Karsten, could you please take a look at fixing this?
>
> drivers/isdn/hisax/hscx_irq.c: In function `hscx_interrupt':
> drivers/isdn/hisax/hscx_irq.c:201: warning: comparison is always 1 due to width of bit-field
>
> It's due to
>
> (PACKET_NOACK != bcs->tx_skb->pkt_type)
>
> pkt_type is only three bit wide.
>
I think this should fix it for the moment, pkt_type 7 is not used yet and
this is only used internal in hisax.
Signed-off-by: Karsten keil <kkeil@suse.de>
diff -ur a/drivers/isdn/hisax/hisax.h b/drivers/isdn/hisax/hisax.h
--- a/drivers/isdn/hisax/hisax.h 2005-08-29 01:41:01.000000000 +0200
+++ b/drivers/isdn/hisax/hisax.h 2006-02-01 12:39:21.000000000 +0100
@@ -217,7 +217,7 @@
#define GROUP_TEI 127
#define TEI_SAPI 63
#define CTRL_SAPI 0
-#define PACKET_NOACK 250
+#define PACKET_NOACK 7
/* Layer2 Flags */
--
Karsten Keil
SuSE Labs
ISDN development
parent reply other threads:[~2006-02-01 11:51 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20060201010406.05f55c09.akpm@osdl.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060201115134.GA8219@pingi.kke.suse.de \
--to=kkeil@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®