* Re: ISDN warning
[not found] <20060201010406.05f55c09.akpm@osdl.org>
@ 2006-02-01 11:51 ` Karsten Keil
0 siblings, 0 replies; only message in thread
From: Karsten Keil @ 2006-02-01 11:51 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, Linus Torvalds
On Wed, Feb 01, 2006 at 01:04:06AM -0800, Andrew Morton wrote:
>
> Karsten, could you please take a look at fixing this?
>
> drivers/isdn/hisax/hscx_irq.c: In function `hscx_interrupt':
> drivers/isdn/hisax/hscx_irq.c:201: warning: comparison is always 1 due to width of bit-field
>
> It's due to
>
> (PACKET_NOACK != bcs->tx_skb->pkt_type)
>
> pkt_type is only three bit wide.
>
I think this should fix it for the moment, pkt_type 7 is not used yet and
this is only used internal in hisax.
Signed-off-by: Karsten keil <kkeil@suse.de>
diff -ur a/drivers/isdn/hisax/hisax.h b/drivers/isdn/hisax/hisax.h
--- a/drivers/isdn/hisax/hisax.h 2005-08-29 01:41:01.000000000 +0200
+++ b/drivers/isdn/hisax/hisax.h 2006-02-01 12:39:21.000000000 +0100
@@ -217,7 +217,7 @@
#define GROUP_TEI 127
#define TEI_SAPI 63
#define CTRL_SAPI 0
-#define PACKET_NOACK 250
+#define PACKET_NOACK 7
/* Layer2 Flags */
--
Karsten Keil
SuSE Labs
ISDN development
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-02-01 11:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20060201010406.05f55c09.akpm@osdl.org>
2006-02-01 11:51 ` ISDN warning Karsten Keil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®