* [PATCH] no need to check pointers passed to vfree for NULL in sound/drivers/vx/vx_pcm.c
@ 2006-02-04 20:26 Jesper Juhl
0 siblings, 0 replies; only message in thread
From: Jesper Juhl @ 2006-02-04 20:26 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: Takashi Iwai, Jesper Juhl
It's pointless checking pointers about to be passed to vfree() for NULL.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
sound/drivers/vx/vx_pcm.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
--- linux-2.6.16-rc2-git1-orig/sound/drivers/vx/vx_pcm.c 2006-02-04 14:44:23.000000000 +0100
+++ linux-2.6.16-rc2-git1/sound/drivers/vx/vx_pcm.c 2006-02-04 21:23:26.000000000 +0100
@@ -98,10 +98,9 @@ static int snd_pcm_alloc_vmalloc_buffer(
static int snd_pcm_free_vmalloc_buffer(struct snd_pcm_substream *subs)
{
struct snd_pcm_runtime *runtime = subs->runtime;
- if (runtime->dma_area) {
- vfree(runtime->dma_area);
- runtime->dma_area = NULL;
- }
+
+ vfree(runtime->dma_area);
+ runtime->dma_area = NULL;
return 0;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-02-04 20:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-02-04 20:26 [PATCH] no need to check pointers passed to vfree for NULL in sound/drivers/vx/vx_pcm.c Jesper Juhl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome