[PATCH -mm] swsusp: fix mistake in documentation

[PATCH -mm] swsusp: fix mistake in documentation

[Rafael J. Wysocki]

Hi,

This patch fixes a mistake in the swsusp documentation.

Please apply.

Greetings,
Rafael


Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

 Documentation/power/swsusp.txt |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

Index: linux-2.6.16-rc2-mm1/Documentation/power/swsusp.txt
===================================================================
--- linux-2.6.16-rc2-mm1.orig/Documentation/power/swsusp.txt
+++ linux-2.6.16-rc2-mm1/Documentation/power/swsusp.txt
@@ -344,7 +344,6 @@ Q: How do I make suspend more verbose?
 
 A: If you want to see any non-error kernel messages on the virtual
 terminal the kernel switches to during suspend, you have to set the
-kernel console loglevel to at least 4 (KERN_WARNING), for example by
-doing
+kernel console loglevel to at least 5, for example by doing
 
-	echo 4 > /proc/sys/kernel/printk
+	echo 5 > /proc/sys/kernel/printk

Re: [PATCH -mm] swsusp: fix mistake in documentation

[Pavel Machek]

On Pá 10-02-06 13:14:44, Rafael J. Wysocki wrote:
> Hi,
> 
> This patch fixes a mistake in the swsusp documentation.
> 
> Please apply.
> 
> Greetings,
> Rafael

BTW, I believe that Andrew hates these Hi, Please apply and greatings
in patches; because he has to manually strip them down. There's some
'---' convention to work around them, but it is probably easier to
just be "rude" with him and only pass changelog in the mail. Not sure
what to do with diffstat. 

> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
ACK, if it is worth anything.

I got these in mail today:

18   T 10-02-06 akpm@osdl.org        ( 144) - swsusp-low-level-interface-rev-2-fix.patch removed fro  
19   T 10-02-06 akpm@osdl.org        ( 107) - suspend-to-ram-allow-video-options-to-be-set-at-runtim  
20   T 10-02-06 akpm@osdl.org        (  84) - swsusp-userland-interface-update.patch removed from -m  
21   T 10-02-06 akpm@osdl.org        ( 101) - suspend-update-documentation.patch removed from -mm tr  
22   T 10-02-06 akpm@osdl.org        ( 108) - led-add-sharp-charger-status-led-trigger-tidy.patch re

...I quite like those patches, and I do not see them going to
Linus. Should I just be more patient, or did they go into some
top-secret-tree I do not know about (but not yet to Linus)?

								Pavel
-- 
Web maintainer for suspend.sf.net (www.sf.net/projects/suspend) wanted...

Re: [PATCH -mm] swsusp: fix mistake in documentation

[Andrew Morton]

Pavel Machek <pavel@suse.cz> wrote:
>
> On Pá 10-02-06 13:14:44, Rafael J. Wysocki wrote:
> > Hi,
> > 
> > This patch fixes a mistake in the swsusp documentation.
> > 
> > Please apply.
> > 
> > Greetings,
> > Rafael
> 
> BTW, I believe that Andrew hates these Hi, Please apply and greatings
> in patches; because he has to manually strip them down. There's some
> '---' convention to work around them, but it is probably easier to
> just be "rude" with him and only pass changelog in the mail. Not sure
> what to do with diffstat. 

diffstats are nice.  Yes, please put them after the ^---

wrt changelogs: yes, I do edit away all the fluff, but it doesn't take long.

This is totally anal, but my pet peeve is changelogs which start with "This
patch frobs the nozzle to ..".  I often change that to "Frob the nozzle
to...", because the "This patch ...." stuff is wholly redundant once the
thing hits the git tree.

What's remarkable is how many English sentences still make sense if you
blindly convert "This patch <word>s ..." into "<Word> ...".  It's
practically automatable.

<we shall now resume normal programming>

> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> ACK, if it is worth anything.
> 
> I got these in mail today:
> 
> 18   T 10-02-06 akpm@osdl.org        ( 144) - swsusp-low-level-interface-rev-2-fix.patch removed fro  
> 19   T 10-02-06 akpm@osdl.org        ( 107) - suspend-to-ram-allow-video-options-to-be-set-at-runtim  
> 20   T 10-02-06 akpm@osdl.org        (  84) - swsusp-userland-interface-update.patch removed from -m  
> 21   T 10-02-06 akpm@osdl.org        ( 101) - suspend-update-documentation.patch removed from -mm tr  
> 22   T 10-02-06 akpm@osdl.org        ( 108) - led-add-sharp-charger-status-led-trigger-tidy.patch re
> 
> ...I quite like those patches, and I do not see them going to
> Linus. Should I just be more patient, or did they go into some
> top-secret-tree I do not know about (but not yet to Linus)?

Ah, sorry.  I had a big consolidation yesterday: folded over 50 fixup
patches into their parent patches.