From: Bastian Blank <bastian@waldi.eu.org>
To: Christoph Hellwig <hch@lst.de>
Cc: akpm@osdl.org, schwidefsky@de.ibm.com, linux390@de.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] dasd: cleanup dasd_ioctl
Date: Sun, 12 Feb 2006 19:03:08 +0100 [thread overview]
Message-ID: <20060212180308.GA24896@wavehammer.waldi.eu.org> (raw)
In-Reply-To: <20060212173855.GB26035@lst.de>
[-- Attachment #1: Type: text/plain, Size: 880 bytes --]
On Sun, Feb 12, 2006 at 06:38:55PM +0100, Christoph Hellwig wrote:
> static int
> -dasd_ioctl_api_version(struct block_device *bdev, int no, long args)
> +dasd_ioctl_api_version(void __user *argp)
> {
> int ver = DASD_API_VERSION;
> - return put_user(ver, (int __user *) args);
> + return put_user(ver, (int *)argp);
> }
Doesn't this need to be "int __user *"?
> +long
> +dasd_compat_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
> {
> - int i;
> + int rval;
>
> - for (i = 0; dasd_ioctls[i].no != -1; i++)
> - dasd_ioctl_no_unregister(NULL, dasd_ioctls[i].no,
> - dasd_ioctls[i].fn);
> + lock_kernel();
> + rval = dasd_ioctl(filp->f_dentry->d_inode, filp, cmd, arg);
> + unlock_kernel();
The lock_kernel looks spurious.
Bastian
--
Conquest is easy. Control is not.
-- Kirk, "Mirror, Mirror", stardate unknown
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2006-02-12 18:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-12 17:38 Christoph Hellwig
2006-02-12 18:03 ` Bastian Blank [this message]
2006-02-12 18:12 ` Christoph Hellwig
2006-02-13 9:53 ` Bastian Blank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060212180308.GA24896@wavehammer.waldi.eu.org \
--to=bastian@waldi.eu.org \
--cc=akpm@osdl.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome