From: Bastian Blank <bastian@waldi.eu.org>
To: Christoph Hellwig <hch@lst.de>
Cc: akpm@osdl.org, schwidefsky@de.ibm.com, linux390@de.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] dasd: cleanup dasd_ioctl
Date: Mon, 13 Feb 2006 10:53:20 +0100 [thread overview]
Message-ID: <20060213095319.GA26627@wavehammer.waldi.eu.org> (raw)
In-Reply-To: <20060212173855.GB26035@lst.de>
[-- Attachment #1: Type: text/plain, Size: 761 bytes --]
On Sun, Feb 12, 2006 at 06:38:55PM +0100, Christoph Hellwig wrote:
> @@ -480,68 +389,90 @@
> * Set read only
> */
> static int
> -dasd_ioctl_set_ro(struct block_device *bdev, int no, long args)
> +dasd_ioctl_set_ro(struct block_device *bdev, void __user *argp)
> {
> - struct dasd_device *device;
> - int intval, rc;
> + struct dasd_device *device = bdev->bd_disk->private_data;
> + int intval;
>
> if (!capable(CAP_SYS_ADMIN))
> return -EACCES;
> if (bdev != bdev->bd_contains)
> // ro setting is not allowed for partitions
> return -EINVAL;
> - if (get_user(intval, (int __user *) args))
> + if (get_user(intval, (int *)argp))
> return -EFAULT;
I think this is another candidate for "int __user *".
Bastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2006-02-13 9:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-12 17:38 Christoph Hellwig
2006-02-12 18:03 ` Bastian Blank
2006-02-12 18:12 ` Christoph Hellwig
2006-02-13 9:53 ` Bastian Blank [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060213095319.GA26627@wavehammer.waldi.eu.org \
--to=bastian@waldi.eu.org \
--cc=akpm@osdl.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome