* Re: kbuild: fix make -jN with multiple targets with O=... [not found] <200601170510.k0H5AtSJ005682@hera.kernel.org> @ 2006-02-15 4:04 ` Benjamin LaHaise 2006-02-15 4:12 ` Andrew Morton 0 siblings, 1 reply; 3+ messages in thread From: Benjamin LaHaise @ 2006-02-15 4:04 UTC (permalink / raw) To: akpm; +Cc: Linux Kernel Mailing List Hello folks, This patch causes a ~95% increase in build time for the kernel. Before: 4m21s after: 8m1.403s. Can we revert this until another approach is found? -ben On Mon, Jan 16, 2006 at 09:10:55PM -0800, Linux Kernel Mailing List wrote: tree b918bb866edc339d51b2b71176265f6d424600e7 parent 60f33b80443a3e7e79e2a3ddc625ab6246a61d3d author Sam Ravnborg <sam@mars.ravnborg.org> Sun, 15 Jan 2006 20:02:31 +0100 committer Sam Ravnborg <sam@mars.ravnborg.org> Sun, 15 Jan 2006 20:02:31 +0100 kbuild: fix make -jN with multiple targets with O=... The way multiple targets was handled with make O=... broke because for each high-level target make spawned a parallel make resulting in a broken build. Reported by Keith Owens <kaos@ocs.com.au> Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Makefile | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index deedaf7..b3dd9db 100644 --- a/Makefile +++ b/Makefile @@ -106,12 +106,13 @@ KBUILD_OUTPUT := $(shell cd $(KBUILD_OUT $(if $(KBUILD_OUTPUT),, \ $(error output directory "$(saved-output)" does not exist)) -.PHONY: $(MAKECMDGOALS) +.PHONY: $(MAKECMDGOALS) cdbuilddir +$(MAKECMDGOALS) _all: cdbuilddir -$(filter-out _all,$(MAKECMDGOALS)) _all: +cdbuilddir: $(if $(KBUILD_VERBOSE:1=),@)$(MAKE) -C $(KBUILD_OUTPUT) \ KBUILD_SRC=$(CURDIR) \ - KBUILD_EXTMOD="$(KBUILD_EXTMOD)" -f $(CURDIR)/Makefile $@ + KBUILD_EXTMOD="$(KBUILD_EXTMOD)" -f $(CURDIR)/Makefile $(MAKECMDGOALS) # Leave processing to above invocation of make skip-makefile := 1 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: kbuild: fix make -jN with multiple targets with O=... 2006-02-15 4:04 ` kbuild: fix make -jN with multiple targets with O= Benjamin LaHaise @ 2006-02-15 4:12 ` Andrew Morton 2006-02-15 15:38 ` Benjamin LaHaise 0 siblings, 1 reply; 3+ messages in thread From: Andrew Morton @ 2006-02-15 4:12 UTC (permalink / raw) To: Benjamin LaHaise; +Cc: linux-kernel, Sam Ravnborg Benjamin LaHaise <bcrl@kvack.org> wrote: > > Hello folks, > > This patch causes a ~95% increase in build time for the kernel. Before: > 4m21s after: 8m1.403s. Can we revert this until another approach is found? > Yowch. Is that with a regular old build-in-place, or is it specific to out-of-tree builds, or what? > -ben > > On Mon, Jan 16, 2006 at 09:10:55PM -0800, Linux Kernel Mailing List wrote: > tree b918bb866edc339d51b2b71176265f6d424600e7 > parent 60f33b80443a3e7e79e2a3ddc625ab6246a61d3d > author Sam Ravnborg <sam@mars.ravnborg.org> Sun, 15 Jan 2006 20:02:31 +0100 > committer Sam Ravnborg <sam@mars.ravnborg.org> Sun, 15 Jan 2006 20:02:31 +0100 > > kbuild: fix make -jN with multiple targets with O=... > > The way multiple targets was handled with make O=... > broke because for each high-level target make spawned > a parallel make resulting in a broken build. > Reported by Keith Owens <kaos@ocs.com.au> > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > > Makefile | 7 ++++--- > 1 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/Makefile b/Makefile > index deedaf7..b3dd9db 100644 > --- a/Makefile > +++ b/Makefile > @@ -106,12 +106,13 @@ KBUILD_OUTPUT := $(shell cd $(KBUILD_OUT > $(if $(KBUILD_OUTPUT),, \ > $(error output directory "$(saved-output)" does not exist)) > > -.PHONY: $(MAKECMDGOALS) > +.PHONY: $(MAKECMDGOALS) cdbuilddir > +$(MAKECMDGOALS) _all: cdbuilddir > > -$(filter-out _all,$(MAKECMDGOALS)) _all: > +cdbuilddir: > $(if $(KBUILD_VERBOSE:1=),@)$(MAKE) -C $(KBUILD_OUTPUT) \ > KBUILD_SRC=$(CURDIR) \ > - KBUILD_EXTMOD="$(KBUILD_EXTMOD)" -f $(CURDIR)/Makefile $@ > + KBUILD_EXTMOD="$(KBUILD_EXTMOD)" -f $(CURDIR)/Makefile $(MAKECMDGOALS) > > # Leave processing to above invocation of make > skip-makefile := 1 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: kbuild: fix make -jN with multiple targets with O=... 2006-02-15 4:12 ` Andrew Morton @ 2006-02-15 15:38 ` Benjamin LaHaise 0 siblings, 0 replies; 3+ messages in thread From: Benjamin LaHaise @ 2006-02-15 15:38 UTC (permalink / raw) To: Andrew Morton; +Cc: linux-kernel, Sam Ravnborg On Tue, Feb 14, 2006 at 08:12:57PM -0800, Andrew Morton wrote: > Benjamin LaHaise <bcrl@kvack.org> wrote: > > > > Hello folks, > > > > This patch causes a ~95% increase in build time for the kernel. Before: > > 4m21s after: 8m1.403s. Can we revert this until another approach is found? > > > > Yowch. Is that with a regular old build-in-place, or is it specific to > out-of-tree builds, or what? It's just a plain old x86-64 build in place on Fedora. I'm game for testing any alternatives, but my kbuild-foo is not good enough to discern what the patch is trying to do and why it makes make unhappy. -ben -- "Ladies and gentlemen, I'm sorry to interrupt, but the police are here and they've asked us to stop the party." Don't Email: <dont@kvack.org>. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-02-15 15:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <200601170510.k0H5AtSJ005682@hera.kernel.org>
2006-02-15 4:04 ` kbuild: fix make -jN with multiple targets with O= Benjamin LaHaise
2006-02-15 4:12 ` Andrew Morton
2006-02-15 15:38 ` Benjamin LaHaise
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®