From: Andrew Morton <akpm@osdl.org>
To: Kyle McMartin <kyle@parisc-linux.org>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Generic is_compat_task helper
Date: Thu, 16 Feb 2006 21:49:39 -0800 [thread overview]
Message-ID: <20060216214939.78aebcbb.akpm@osdl.org> (raw)
In-Reply-To: <20060217025242.GM13492@quicksilver.road.mcmartin.ca>
Kyle McMartin <kyle@parisc-linux.org> wrote:
>
> Implement a generic is_compat_task function. It should only be used
> when absolutely necessary. For example, to clean up the per-architecture
> tests in drivers/input/evdev.c.
>
> Prototype is such that the existing asm-x86_64 helper needs no change.
>
> Architecture maintainers must add an appropriate implementation to
> asm/compat.h, if needed.
>
> ...
>
> +static inline int __is_compat_task(struct task_struct *t)
> +{
> + return (personality(t->personality) == PER_LINUX32);
> +}
> +
What continues to bug me about this (in a high-level hand-wavy sort of way)
is that this is an attribute of the mm_struct, not of the task_struct.
next prev parent reply other threads:[~2006-02-17 5:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-17 2:52 Kyle McMartin
2006-02-17 5:49 ` Andrew Morton [this message]
2006-02-17 5:58 ` Paul Mackerras
2006-02-17 6:01 ` Stephen Rothwell
2006-02-17 7:03 ` David S. Miller
2006-02-17 7:45 ` Issue in using more number of devices with BFS setup in AS4 Srikanth Venkataraman
2006-02-17 14:11 ` [PATCH] Generic is_compat_task helper Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060216214939.78aebcbb.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=kyle@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®