From: Kyle McMartin <kyle@parisc-linux.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Kyle McMartin <kyle@parisc-linux.org>,
torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Generic is_compat_task helper
Date: Fri, 17 Feb 2006 09:11:08 -0500 [thread overview]
Message-ID: <20060217141108.GO13492@quicksilver.road.mcmartin.ca> (raw)
In-Reply-To: <20060216214939.78aebcbb.akpm@osdl.org>
On Thu, Feb 16, 2006 at 09:49:39PM -0800, Andrew Morton wrote:
> > +static inline int __is_compat_task(struct task_struct *t)
> > +{
> > + return (personality(t->personality) == PER_LINUX32);
> > +}
> > +
>
> What continues to bug me about this (in a high-level hand-wavy sort of way)
> is that this is an attribute of the mm_struct, not of the task_struct.
>
I'm not sure I agree, I can't find any real defined use for PER_LINUX32,
as opposed to PER_LINUX_32BIT, which is | ADDR_LIMIT_32BIT. That said,
I'm not opposed to moving parisc to use TIF_32BIT, in fact, I had this
in mind when I give the entrypoints a crapectomy.
Cheers,
Kyle
prev parent reply other threads:[~2006-02-17 14:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-17 2:52 Kyle McMartin
2006-02-17 5:49 ` Andrew Morton
2006-02-17 5:58 ` Paul Mackerras
2006-02-17 6:01 ` Stephen Rothwell
2006-02-17 7:03 ` David S. Miller
2006-02-17 7:45 ` Issue in using more number of devices with BFS setup in AS4 Srikanth Venkataraman
2006-02-17 14:11 ` Kyle McMartin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060217141108.GO13492@quicksilver.road.mcmartin.ca \
--to=kyle@parisc-linux.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®