mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* powerpc: Fix accidentally-working typo in __pud_free_tlb
@ 2006-02-17  3:54 David Gibson
  0 siblings, 0 replies; only message in thread
From: David Gibson @ 2006-02-17  3:54 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Paul Mackerras, Benjamin Herrenschmidt, linuxppc64-dev, linux-kernel

Andrew, Paulus, please apply.

One of the parameters to the __pud_free_tlb() macro for powerpc is
incorrect (see patch) .  We get away with it by accident, because the
one place the macro is called, the second parameter is a variable
named "pud".

Nonetheless, this should be fixed for 2.6.16.

Signed-off-by: David Gibson <dwg@au1.ibm.com>

Index: working-2.6/include/asm-powerpc/pgalloc.h
===================================================================
--- working-2.6.orig/include/asm-powerpc/pgalloc.h	2006-01-16 13:02:29.000000000 +1100
+++ working-2.6/include/asm-powerpc/pgalloc.h	2006-02-17 14:48:13.000000000 +1100
@@ -146,7 +146,7 @@ extern void pgtable_free_tlb(struct mmu_
 	pgtable_free_tlb(tlb, pgtable_free_cache(pmd, \
 		PMD_CACHE_NUM, PMD_TABLE_SIZE-1))
 #ifndef CONFIG_PPC_64K_PAGES
-#define __pud_free_tlb(tlb, pmd)	\
+#define __pud_free_tlb(tlb, pud)	\
 	pgtable_free_tlb(tlb, pgtable_free_cache(pud, \
 		PUD_CACHE_NUM, PUD_TABLE_SIZE-1))
 #endif /* CONFIG_PPC_64K_PAGES */

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-02-17  4:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-02-17  3:54 powerpc: Fix accidentally-working typo in __pud_free_tlb David Gibson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®