From: Ashok Raj <ashok.raj@intel.com>
To: Andi Kleen <ak@muc.de>, Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, discuss@x86-64.org,
Len Brown <len.brown@intel.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
Ashok Raj <ashok.raj@intel.com>
Subject: [patch 1/5] Remove entries in /sys/firmware/acpi for processor also.
Date: Tue, 28 Feb 2006 16:15:58 -0800 [thread overview]
Message-ID: <20060301001722.646596000@araj-sfield> (raw)
In-Reply-To: <20060301001557.318047000@araj-sfield>
[-- Attachment #1: remove-processor-entries-on-eject --]
[-- Type: text/plain, Size: 1106 bytes --]
Processor entries under /sys/firmware/acpi/namespace/ACPI/_SB/CPU*
were not being removed due to acpi_bus_trim not asking for it
just for processors. Without which a new hot-add after a remove doesnt call
appropriate init functions resulting in subsequent hot-add for same
cpu failing.
Not clear why we restricted that to non-processor devices.
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
-----------------------------------------------------
drivers/acpi/scan.c | 5 +----
1 files changed, 1 insertion(+), 4 deletions(-)
Index: linux-2.6.16-rc4-mm1/drivers/acpi/scan.c
===================================================================
--- linux-2.6.16-rc4-mm1.orig/drivers/acpi/scan.c
+++ linux-2.6.16-rc4-mm1/drivers/acpi/scan.c
@@ -434,10 +434,7 @@ acpi_eject_store(struct acpi_device *dev
islockable = device->flags.lockable;
handle = device->handle;
- if (type == ACPI_TYPE_PROCESSOR)
- result = acpi_bus_trim(device, 0);
- else
- result = acpi_bus_trim(device, 1);
+ result = acpi_bus_trim(device, 1);
if (!result)
result = acpi_eject_operation(handle, islockable);
--
next prev parent reply other threads:[~2006-02-28 23:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-01 0:15 [patch 0/5] ACPI based physical CPU hotplug support for x86_64 Ashok Raj
2006-03-01 0:15 ` Ashok Raj [this message]
2006-03-01 0:15 ` [patch 2/5] Remove unnecessary lapic definition from acpidef.h Ashok Raj
2006-03-01 12:54 ` Andi Kleen
2006-03-01 0:16 ` [patch 3/5] Support physical cpu hotplug for x86_64 Ashok Raj
2006-03-01 0:16 ` [patch 4/5] Patch to limit present cpus to fake cpu hot-add testing Ashok Raj
2006-03-01 0:16 ` [patch 5/5] Enable SCI_EMULATE to manually simulate physical hotplug testing Ashok Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060301001722.646596000@araj-sfield \
--to=ashok.raj@intel.com \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=discuss@x86-64.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®