From: Andi Kleen <ak@muc.de>
To: Ashok Raj <ashok.raj@intel.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, discuss@x86-64.org
Subject: Re: [patch 2/5] Remove unnecessary lapic definition from acpidef.h
Date: 1 Mar 2006 13:54:05 +0100 [thread overview]
Date: Wed, 1 Mar 2006 13:54:05 +0100 [thread overview]
Message-ID: <20060301125405.GB72515@muc.de> (raw)
In-Reply-To: <20060301001722.746570000@araj-sfield>
On Tue, Feb 28, 2006 at 04:15:59PM -0800, Ashok Raj wrote:
> Dont know why this exists... just happened to trip me when i used a
> variable name with lapic, and until i looked at the pre-processed
> output couldnt figure out we had a lame definition like this.
>
> Hope iam not breaking anything here..
No, the file is a mess anyways.
>
> Signed-off-by: Ashok Raj <ashok.raj@intel.com>
> ------------------------------------------------
> include/asm-i386/apicdef.h | 1 -
> include/asm-x86_64/apicdef.h | 2 --
> 2 files changed, 3 deletions(-)
>
> Index: linux-2.6.16-rc1-mm4/include/asm-i386/apicdef.h
> ===================================================================
> --- linux-2.6.16-rc1-mm4.orig/include/asm-i386/apicdef.h
> +++ linux-2.6.16-rc1-mm4/include/asm-i386/apicdef.h
> @@ -120,7 +120,6 @@
> */
> #define u32 unsigned int
Like this should go too.
>
> -#define lapic ((volatile struct local_apic *)APIC_BASE)
I'll take a stab at cleaning it up.
Thanks,
-Andi
next prev parent reply other threads:[~2006-03-01 12:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-01 0:15 [patch 0/5] ACPI based physical CPU hotplug support for x86_64 Ashok Raj
2006-03-01 0:15 ` [patch 1/5] Remove entries in /sys/firmware/acpi for processor also Ashok Raj
2006-03-01 0:15 ` [patch 2/5] Remove unnecessary lapic definition from acpidef.h Ashok Raj
2006-03-01 12:54 ` Andi Kleen [this message]
2006-03-01 0:16 ` [patch 3/5] Support physical cpu hotplug for x86_64 Ashok Raj
2006-03-01 0:16 ` [patch 4/5] Patch to limit present cpus to fake cpu hot-add testing Ashok Raj
2006-03-01 0:16 ` [patch 5/5] Enable SCI_EMULATE to manually simulate physical hotplug testing Ashok Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060301125405.GB72515@muc.de \
--to=ak@muc.de \
--cc=akpm@osdl.org \
--cc=ashok.raj@intel.com \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®