mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Hal Rosenstock <halr@voltaire.com>
Cc: Roland Dreier <rdreier@cisco.com>, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, openib-general@openib.org,
	davem@davemloft.net
Subject: Re: [openib-general] Re: [PATCH 8 of 20] ipath - sysfs support for core driver
Date: Fri, 10 Mar 2006 08:54:52 -0800	[thread overview]
Message-ID: <20060310165452.GA11382@suse.de> (raw)
In-Reply-To: <1142003287.4331.28584.camel@hal.voltaire.com>

On Fri, Mar 10, 2006 at 10:08:10AM -0500, Hal Rosenstock wrote:
> On Fri, 2006-03-10 at 09:59, Roland Dreier wrote:
> >     Greg> The main issue is that if you create a sysfs file like this,
> >     Greg> and then in 3 months realize that you need to change one of
> >     Greg> those characters to be something else, you are in big
> >     Greg> trouble...
> > 
> > I think that PortInfo and NodeInfo might be fair game for sysfs files,
> > because they are actually defined in the IB spec with a binary format
> > that is sent on the wire.  So they're not going to change.
> 
> Not true; There have been and likely will be more upward compatible
> changes (especially to PortInfo).

Great, that means they should NOT be exported to userspace in this
fashion...

> > On the other hand it's not clear to me why using that wire protocol as
> > an interface to userspace is a good idea...

Agreed.

thanks,

greg k-h

  reply	other threads:[~2006-03-10 16:55 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-10  0:35 [PATCH 0 of 20] [RFC] ipath driver - another round for review Bryan O'Sullivan
2006-03-10  0:35 ` [PATCH 1 of 20] ipath - core driver header files Bryan O'Sullivan
2006-03-10  0:35 ` [PATCH 2 of 20] ipath - core device driver Bryan O'Sullivan
2006-03-10  0:35 ` [PATCH 3 of 20] ipath - copy and send routines for sending an skb Bryan O'Sullivan
2006-03-10  0:35 ` [PATCH 4 of 20] ipath - support for HyperTransport devices Bryan O'Sullivan
2006-03-10  0:35 ` [PATCH 5 of 20] ipath - support for PCI Express devices Bryan O'Sullivan
2006-03-10  0:35 ` [PATCH 6 of 20] ipath - chip initialisation code Bryan O'Sullivan
2006-03-10  0:35 ` [PATCH 7 of 20] ipath - misc driver support code Bryan O'Sullivan
2006-03-10  0:35 ` [PATCH 8 of 20] ipath - sysfs support for core driver Bryan O'Sullivan
2006-03-10  1:11   ` Greg KH
2006-03-10  5:09     ` Bryan O'Sullivan
2006-03-05  3:08       ` Pavel Machek
2006-03-10  6:37       ` Greg KH
2006-03-10 14:59         ` Roland Dreier
2006-03-10 15:08           ` [openib-general] " Hal Rosenstock
2006-03-10 16:54             ` Greg KH [this message]
2006-03-10 17:05               ` Bryan O'Sullivan
2006-03-10  0:35 ` [PATCH 9 of 20] ipath - char devices for diagnostics and lightweight subnet management Bryan O'Sullivan
2006-03-10  0:45   ` Roland Dreier
2006-03-10  0:47     ` Bryan O'Sullivan
2006-03-10  0:52       ` Roland Dreier
2006-03-10  0:35 ` [PATCH 10 of 20] ipath - support for userspace apps using core driver Bryan O'Sullivan
2006-03-10  0:35 ` [PATCH 11 of 20] ipath - layering interfaces used by higher-level driver code Bryan O'Sullivan
2006-03-10  0:35 ` [PATCH 12 of 20] ipath - infiniband header files Bryan O'Sullivan
2006-03-10  0:35 ` [PATCH 13 of 20] ipath - infiniband UC and UD protocol support Bryan O'Sullivan
2006-03-10  0:35 ` [PATCH 14 of 20] ipath - infiniband RC " Bryan O'Sullivan
2006-03-10  0:35 ` [PATCH 15 of 20] ipath - misc infiniband code, part 1 Bryan O'Sullivan
2006-03-10  0:35 ` [PATCH 16 of 20] ipath - misc infiniband code, part 2 Bryan O'Sullivan
2006-03-10  0:35 ` [PATCH 17 of 20] ipath - infiniband verbs support Bryan O'Sullivan
2006-03-10  0:35 ` [PATCH 18 of 20] ipath - kbuild infrastructure Bryan O'Sullivan
2006-03-13 18:10   ` Adrian Bunk
2006-03-13 18:38     ` Robert Walsh
2006-03-13 19:24     ` Bryan O'Sullivan
2006-03-13 19:36       ` Sam Ravnborg
2006-03-13 19:39         ` Bryan O'Sullivan
2006-03-10  0:35 ` [PATCH 19 of 20] ipath - integrate driver into infiniband " Bryan O'Sullivan
2006-03-10  0:35 ` [PATCH 20 of 20] ipath - ethernet emulation driver Bryan O'Sullivan
2006-03-10 15:35 ` [openib-general] [PATCH 0 of 20] [RFC] ipath driver - another round for review Michael S. Tsirkin
2006-03-10 16:02   ` Bryan O'Sullivan
2006-03-10 17:48     ` Grant Grundler
2006-03-10 17:54       ` Bryan O'Sullivan
2006-03-10 22:30         ` Grant Grundler
2006-03-11  4:20           ` Bryan O'Sullivan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060310165452.GA11382@suse.de \
    --to=gregkh@suse.de \
    --cc=akpm@osdl.org \
    --cc=davem@davemloft.net \
    --cc=halr@voltaire.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openib-general@openib.org \
    --cc=rdreier@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome