From: Andrew Morton <akpm@osdl.org>
To: Shaohua Li <shaohua.li@intel.com>
Cc: ntl@pobox.com, ashok.raj@intel.com, olel@ans.pl,
venkatesh.pallipadi@intel.com, linux-kernel@vger.kernel.org,
suresh.b.siddha@intel.com, rajesh.shah@intel.com, ak@muc.de
Subject: Re: More than 8 CPUs detected and CONFIG_X86_PC cannot handle it on 2.6.16-rc6
Date: Tue, 14 Mar 2006 23:31:38 -0800 [thread overview]
Message-ID: <20060314233138.009414b4.akpm@osdl.org> (raw)
In-Reply-To: <1142403500.26706.2.camel@sli10-desk.sh.intel.com>
Shaohua Li <shaohua.li@intel.com> wrote:
>
> On Wed, 2006-03-15 at 13:44 +0800, Nathan Lynch wrote:
> > Ashok Raj wrote:
> > > On Mon, Mar 13, 2006 at 02:22:23PM -0800, Andrew Morton wrote:
> > > >
> > > > And does it affect pretend-x86-hotplug, or is it only affecting
> > real hotplug?
> > > >
> > > its no more pretend-x86, in the past we used to put the cpu in
> > idle(),
> > > now we do put the cpu in halt and bring back by another startup ipi,
> > just like
> > > boot sequence, both for x86 and x86_64.
> >
> > That's actually broken since 2.6.14 (at least on my P3 box); please
> > see:
> >
> > Subject: i386 cpu hotplug bug - instant reboot when onlining secondary
> >
> > http://lkml.org/lkml/2006/2/19/186
> Works for me. But I saw a warning.
Guys, will you please stop being so cryptic? What worked for you? What
warning? wtf is going on? Who owns this problem, whatever it is?
<head spins>
> linux-2.6.15-root/arch/i386/kernel/cpu/common.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN arch/i386/kernel/cpu/common.c~cpuhp arch/i386/kernel/cpu/common.c
> --- linux-2.6.15/arch/i386/kernel/cpu/common.c~cpuhp 2006-03-14 12:13:43.000000000 +0800
> +++ linux-2.6.15-root/arch/i386/kernel/cpu/common.c 2006-03-14 12:14:12.000000000 +0800
> @@ -605,7 +605,7 @@ void __devinit cpu_init(void)
> /* alloc_bootmem_pages panics on failure, so no check */
> memset(gdt, 0, PAGE_SIZE);
> } else {
> - gdt = (struct desc_struct *)get_zeroed_page(GFP_KERNEL);
> + gdt = (struct desc_struct *)get_zeroed_page(GFP_ATOMIC);
That would be rather a sad thing to have to do. OK if it's during initial
bootup, less OK if it's during CPU hot-add.
next prev parent reply other threads:[~2006-03-15 7:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-12 2:04 Krzysztof Oledzki
2006-03-12 5:03 ` Andrew Morton
2006-03-12 11:04 ` Krzysztof Oledzki
2006-03-12 11:25 ` Andrew Morton
2006-03-12 13:05 ` Krzysztof Oledzki
2006-03-12 15:35 ` Venkatesh Pallipadi
2006-03-12 21:13 ` Krzysztof Oledzki
2006-03-12 22:30 ` Andrew Morton
2006-03-13 19:36 ` Ashok Raj
2006-03-13 19:51 ` Andrew Morton
2006-03-13 20:05 ` Ashok Raj
2006-03-13 22:22 ` Andrew Morton
2006-03-13 23:04 ` Ashok Raj
2006-03-15 5:44 ` Nathan Lynch
2006-03-15 6:18 ` Shaohua Li
2006-03-15 7:31 ` Andrew Morton [this message]
2006-03-15 9:37 ` [PATCH] No need to protect current->group_info in sys_getgroups(), in_group_p() and in_egroup_p() Eric Dumazet
2006-03-20 19:09 ` [PATCH] Use unsigned int types for a faster bsearch Eric Dumazet
2006-03-22 5:06 ` [PATCH] Use __read_mostly on some hot fs variables Eric Dumazet
2006-03-22 5:15 ` Nick Piggin
2006-03-22 6:23 ` [RFC, PATCH] avoid some atomics in open()/close() for monothreaded processes Eric Dumazet
2006-03-22 6:41 ` Andrew Morton
2006-03-22 6:59 ` Eric Dumazet
2006-03-22 7:03 ` Andrew Morton
2006-03-15 18:09 ` More than 8 CPUs detected and CONFIG_X86_PC cannot handle it on 2.6.16-rc6 Ashok Raj
2006-03-15 10:50 Chuck Ebbert
2006-03-15 15:44 ` Krzysztof Oledzki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060314233138.009414b4.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@muc.de \
--cc=ashok.raj@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ntl@pobox.com \
--cc=olel@ans.pl \
--cc=rajesh.shah@intel.com \
--cc=shaohua.li@intel.com \
--cc=suresh.b.siddha@intel.com \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome