mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Fix irda-usb use after use
@ 2006-03-15  3:08 Eugene Teo
  0 siblings, 0 replies; only message in thread
From: Eugene Teo @ 2006-03-15  3:08 UTC (permalink / raw)
  To: Linux Kernel; +Cc: dag

Don't read from free'd memory after calling netif_rx().
docopy is used as a boolean (0 and 1) so unsigned int is sufficient.

Coverity bug #928

Signed-off-by: Eugene Teo <eugene.teo@eugeneteo.net>
 
--- linux-2.6/drivers/net/irda/irda-usb.c~	2006-03-15 10:05:35.000000000 +0800
+++ linux-2.6/drivers/net/irda/irda-usb.c	2006-03-15 11:06:01.000000000 +0800
@@ -740,7 +740,7 @@
 	struct sk_buff *newskb;
 	struct sk_buff *dataskb;
 	struct urb *next_urb;
-	int		docopy;
+	unsigned int len, docopy;
 
 	IRDA_DEBUG(2, "%s(), len=%d\n", __FUNCTION__, urb->actual_length);
 	
@@ -851,10 +851,11 @@
 	dataskb->dev = self->netdev;
 	dataskb->mac.raw  = dataskb->data;
 	dataskb->protocol = htons(ETH_P_IRDA);
+	len = dataskb->len;
 	netif_rx(dataskb);
 
 	/* Keep stats up to date */
-	self->stats.rx_bytes += dataskb->len;
+	self->stats.rx_bytes += len;
 	self->stats.rx_packets++;
 	self->netdev->last_rx = jiffies;
 
-- 
1024D/A6D12F80 print D51D 2633 8DAC 04DB 7265  9BB8 5883 6DAA A6D1 2F80
main(i) { putchar(182623909 >> (i-1) * 5&31|!!(i<7)<<6) && main(++i); }

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-03-15  3:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-03-15  3:08 Fix irda-usb use after use Eugene Teo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®