From: Jiri Benc <jbenc@suse.cz>
To: rusty@rustcorp.com.au
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] modpost: fix buffer overflow
Date: Wed, 15 Mar 2006 15:44:36 +0100 [thread overview]
Message-ID: <20060315154436.4286d2ab@griffin.suse.cz> (raw)
I got SIGABRT in modpost when building a module really deeply nested in
a filesystem (path > 100 chars):
> Building modules, stage 2.
> MODPOST
> *** glibc detected *** scripts/mod/modpost: realloc(): invalid next size: 0x0809f588 ***
> [...]
This patch fixes that problem.
Signed-off-by: Jiri Benc <jbenc@suse.cz>
--- linux-2.6.16-rc6.orig/scripts/mod/modpost.c
+++ linux-2.6.16-rc6/scripts/mod/modpost.c
@@ -552,7 +552,7 @@ void __attribute__((format(printf, 2, 3)
va_start(ap, fmt);
len = vsnprintf(tmp, SZ, fmt, ap);
- if (buf->size - buf->pos < len + 1) {
+ while (buf->size - buf->pos < len + 1) {
buf->size += 128;
buf->p = realloc(buf->p, buf->size);
}
--
Jiri Benc
SUSE Labs
next reply other threads:[~2006-03-15 14:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-15 14:44 Jiri Benc [this message]
2006-03-15 14:55 ` Bernd Petrovitsch
2006-03-15 14:57 ` Bernd Petrovitsch
2006-03-15 15:08 ` Jiri Benc
2006-03-15 15:35 ` Andreas Schwab
2006-03-15 22:51 ` Sam Ravnborg
2006-03-16 13:21 ` Jiri Benc
2006-03-16 15:46 ` Sam Ravnborg
2006-03-16 18:59 ` [PATCH] kbuild: fix buffer overflow in modpost Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060315154436.4286d2ab@griffin.suse.cz \
--to=jbenc@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®